Skip to content

Conversation

@mmusich
Copy link
Contributor

@mmusich mmusich commented Dec 11, 2025

PR description:

This PR modernizes the FourVectorHLT DQM module and updates its associated configuration to follow current cmssw standards and improve maintainability and configurability.

  • Updated the core FourVectorHLT implementation (.cc, .h) to reflect modern C++/CMSSW idioms and remove legacy patterns.
  • Refactored associated configuration fragments (_cff.py, _cfi.py) to align with current HLT DQM configuration conventions.
  • Adjusted monitoring configuration (HLTObjectMonitor, listOfFilters) to incorporate the modernized module interfaces.

PR validation:

The module compiles cleanly within the current CMSSW release.
I generated an input file for testing via the following script:

#!/bin/bash -ex

# cmsrel CMSSW_16_0_X_2025-11-25-2300
# cd CMSSW_16_0_X_2025-11-25-2300/src
# cmsenv
# scram b -j 20

hltGetConfiguration /dev/CMSSW_15_1_0/GRun \
            --globaltag 151X_dataRun3_HLT_v1 \
            --data \
            --unprescale \
            --output minimal \
            --max-events -1 \
            --eras Run3_2025 --l1-emulator uGT --l1 L1Menu_Collisions2025_v1_3_0_xml \
            --input /store/data/Run2025G/EphemeralHLTPhysics0/RAW/v1/000/398/183/00000/002bbd0c-b9ed-4758-b7a6-e2e13149ca34.root  \
            > hltData.py

edmConfigDump hltData.py > dump.py

cmsRun dump.py >& hltData.log

and then analyzed it with:

cmsRun DQM/Integration/python/clients/hlt_dqm_sourceclient-live_cfg.py inputFiles=file:output.root

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Not a backport, no backport needed.

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 11, 2025

cms-bot internal usage

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mmusich for master.

It involves the following packages:

  • DQM/HLTEvF (dqm, hlt)

@Martin-Grunewald, @cmsbuild, @ctarricone, @gabrielmscampos, @mmusich, @nothingface0, @rseidita can you please review it and eventually sign? Thanks.
@missirol, @mtosi this is something you requested to watch as well.
@ftenchini, @mandrenguyen, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@mmusich
Copy link
Contributor Author

mmusich commented Dec 11, 2025

test parameters:

  • addpkg = DQM/Integration

@mmusich
Copy link
Contributor Author

mmusich commented Dec 11, 2025

@cmsbuild, please test

@mmusich
Copy link
Contributor Author

mmusich commented Dec 11, 2025

type ngt

@cmsbuild
Copy link
Contributor

+1

Size: This PR adds an extra 28KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-78faf8/49911/summary.html
COMMIT: 3e6625b
CMSSW: CMSSW_16_0_X_2025-12-11-1100/el8_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/49610/49911/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 1 lines to the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 14 differences found in the comparisons
  • Reco comparison had 4 failed jobs
  • DQMHistoTests: Total files compared: 53
  • DQMHistoTests: Total histograms compared: 4273241
  • DQMHistoTests: Total failures: 114
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 4273107
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 52 files compared)
  • Checked 227 log files, 198 edm output root files, 53 DQM output files
  • TriggerResults: no differences found

@mmusich
Copy link
Contributor Author

mmusich commented Dec 15, 2025

+hlt

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants