Skip to content

Conversation

@civanch
Copy link
Contributor

@civanch civanch commented Dec 12, 2025

PR description:

An attempt to fix initialisation of geometry in unit tests.

PR validation:

private

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for: NO

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 12, 2025

cms-bot internal usage

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @civanch for master.

It involves the following packages:

  • SimG4Core/Application (simulation)
  • SimG4Core/GeometryProducer (simulation)

@civanch, @cmsbuild, @kpedro88, @mdhildreth can you please review it and eventually sign? Thanks.
@bsunanda, @fabiocos, @makortel, @martinamalberti, @rovere, @slomeo this is something you requested to watch as well.
@ftenchini, @mandrenguyen, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@civanch
Copy link
Contributor Author

civanch commented Dec 12, 2025

please test

@iarspider
Copy link
Contributor

please test for CMSSW_16_0_GEANT4_X with cms-sw/cmsdist#10243

@smuzaffar
Copy link
Contributor

please test

lets run tests for default IB too

@cmsbuild
Copy link
Contributor

+1

Size: This PR adds an extra 32KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-63349c/49921/summary.html
COMMIT: e898582
CMSSW: CMSSW_16_0_X_2025-12-11-2300/el8_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/49615/49921/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 2 lines from the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 6 differences found in the comparisons
  • Reco comparison had 4 failed jobs
  • DQMHistoTests: Total files compared: 53
  • DQMHistoTests: Total histograms compared: 4273241
  • DQMHistoTests: Total failures: 70
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 4273151
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 52 files compared)
  • Checked 227 log files, 198 edm output root files, 53 DQM output files
  • TriggerResults: no differences found

@cmsbuild
Copy link
Contributor

-1

Failed Tests: UnitTests RelVals AddOn
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-63349c/49920/summary.html
COMMIT: e898582
CMSSW: CMSSW_16_0_GEANT4_X_2025-12-10-2300/el8_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/49615/49920/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-63349c/49920/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-63349c/49920/git-merge-result

Failed Unit Tests

I found 11 errors in the following unit tests:

---> test materialBudgetTrackerPlots had ERRORS
---> test materialBudgetHGCalPlots had ERRORS
---> test trackerMaterialAnalysisPlots had ERRORS
and more ...

Failed RelVals

The relvals timed out after 4 hours.

Failed AddOn Tests

  • unknown
AddOnTest might have timed out: FAILED -  secs

@civanch
Copy link
Contributor Author

civanch commented Dec 15, 2025

Let us close this PR, because without it we but with the private fix of Geant4 we have working situation.

@civanch civanch closed this Dec 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants