-
Notifications
You must be signed in to change notification settings - Fork 4.6k
[NGT] Add MC truth labels support to NanoAOD reco::Tracks and introduce PixelTracks+RecHits ntuples
#49617
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
cms-bot internal usage |
|
type ngt |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-49617/47150
|
|
A new Pull Request was created by @Parsifal-2045 for master. It involves the following packages:
@Martin-Grunewald, @battibass, @cmsbuild, @ftorrresd, @mmusich can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
mmusich
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor comments.
- The new producer creates ValueMaps to store recoToSim and simToReco information - Generic implementation can be customised providing trackCollection, associator, TPCollection, and TPSelector parameters - The products are meant to be used as external variables for SimpleFlatTableProducers allowing for a-posteriori validation using data stored in the NANOAOD output
- New separate table for recHits (fixed to 16 hits per track) - New autoNANO configuration @Phase2HLTPixelOnly to produce only pixelTracks ntuples (with MC truth labels)
38ee708 to
9f5c8da
Compare
|
test parameters:
|
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-49617/47151
|
|
Pull request #49617 was updated. @Martin-Grunewald, @battibass, @cmsbuild, @ftorrresd, @mmusich can you please check and sign again. |
|
@cmsbuild, please test |
|
+1 Size: This PR adds an extra 32KB to repository Comparison SummarySummary:
|
|
+hlt |
|
enable nano |
|
please test |
|
+1 Size: This PR adds an extra 32KB to repository Comparison SummarySummary:
Nano size comparison Summary:
NANO Comparison SummarySummary:
|
PR description:
This PR adds new tools and NanoAOD content to support Phase-2 HLT pixel-tracking studies with MC truth information:
TrackingAssocValueMapProducerallows to add MC Truth matching labels toreco::Trackobjects, by providing the corresponding associator, the TP collection, and TP selector parameters. It produces value maps based on the usual reco-to-sim and sim-to-reco matching already used for validation.All these features are used in a newly added NanoAOD worfklow:
NANO:@Phase2HLTPixelOnlywhich produces PixelTracks + RecHits ntuples with MC truth label, intended for Phase-2 HLT development.PR validation:
There is no change to existing workflows of physics-related code. The pixel-track NanoAOD tables produce the expected per-track truth labels and hit-level information in local tests.