Bug Fix in Ecal/Hcal Digitizers for FASTPU aka Hybrid PU Mixing

[subirsarkar]

PR description:

A bug was found in Ecal and Hcal Digitizers where std::set was being used to hold the SimHit InputTag for signal and PU events. The order was found to be wrong. The std::set is now removed and the token for signal is directly created from the signal simHit InputTag.

PR validation:

Bug found during validation with officially produced data samples. Post bug-fix validation done with a small privately produced TTbar dataset

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

@suchandradutta @kpedro88 @bsunanda

[cmsbuild]

cms-bot internal usage

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-49618/47154

[cmsbuild]

A new Pull Request was created by @subirsarkar for CMSSW_16_0_FASTPU_X.

It involves the following packages:

• SimCalorimetry/EcalSimProducers (simulation)
• SimCalorimetry/HcalSimProducers (simulation)

@civanch, @cmsbuild, @kpedro88, @mdhildreth can you please review it and eventually sign? Thanks.
@ReyerBand, @abdoulline, @argiro, @bsunanda, @mariadalfonso, @rchatter, @rovere, @sameasy, @thomreis, @wang0jin this is something you requested to watch as well.
@ftenchini, @mandrenguyen, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

[kpedro88]

test parameters:
workflow = 11834.96
relvals_opt = --what upgrade

[kpedro88]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1b0895/49946/summary.html
COMMIT: 7304e93
CMSSW: CMSSW_16_0_FASTPU_X_2025-12-12-2300/el8_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/49618/49946/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially added 207 lines to the logs
• ROOTFileChecks: Some differences in event products or their sizes found
• Reco comparison results: 5 differences found in the comparisons
• Reco comparison had 4 failed jobs
• DQMHistoTests: Total files compared: 53
• DQMHistoTests: Total histograms compared: 4273241
• DQMHistoTests: Total failures: 38
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 4273183
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 52 files compared)
• Checked 227 log files, 198 edm output root files, 53 DQM output files
• TriggerResults: no differences found

[kpedro88]

+simulation

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_16_0_FASTPU_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_16_0_X is complete. This pull request will now be reviewed by the release team before it's merged. @mandrenguyen, @ftenchini, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

[mandrenguyen]

+1