Skip to content

Conversation

@sakura-ngt
Copy link

PR description:

This PR introduces the following changes:

  • Introduce a new module ScoutingRecHitAnalyzer for monitoring reconstructed EB and HBHE rechits in scouting data.
  • Add infrastructure to run the ScoutingRecHitAnalyzer within the DQM framework.
  • Refactor L1 bits handling for scouting in both online and offline sequences.
  • Make the top-level folder name configurable to support calo RecHit monitoring outputs.
  • Update HLT DQM offline sequences to include hltScoutingMonitoringRecHits only for the Run3 Scouting 2025 era via the appropriate era modifier.
  • Support new bookProfile2D method in DQMStore for variable bin size histograms.

PR validation:

Run successfully the following tests:

  • DQM online: scram b runtests_TestDQMOnlineClient-scouting_dqm_sourceclient
  • DQM offfline: runTheMatrix.py -l 16834.0 -t 4 -j 8

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Not a backport, no backport needed. Foreseen to be used in the 2026 pp run.

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 12, 2025

cms-bot internal usage

@sakura-ngt
Copy link
Author

type ngt

@cmsbuild cmsbuild added the ngt label Dec 12, 2025
@cmsbuild
Copy link
Contributor

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-49619/47155

Code check has found code style and quality issues which could be resolved by applying following patch(s)

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @sakura-ngt for master.

It involves the following packages:

  • DQM/HLTEvF (dqm, hlt)
  • DQM/Integration (dqm)
  • DQMOffline/HLTScouting (dqm)
  • DQMServices/Core (dqm)
  • HLTriggerOffline/Scouting (dqm)

@Martin-Grunewald, @cmsbuild, @ctarricone, @gabrielmscampos, @mmusich, @nothingface0, @rseidita can you please review it and eventually sign? Thanks.
@barvic, @batinkov, @francescobrivio, @missirol, @mmusich, @mtosi, @rociovilar, @threus this is something you requested to watch as well.
@ftenchini, @mandrenguyen, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@mmusich
Copy link
Contributor

mmusich commented Dec 12, 2025

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

+1

Size: This PR adds an extra 40KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-33e733/49930/summary.html
COMMIT: 575fbc8
CMSSW: CMSSW_16_0_X_2025-12-12-1100/el8_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/49619/49930/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 200 lines to the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 12 differences found in the comparisons
  • Reco comparison had 4 failed jobs
  • DQMHistoTests: Total files compared: 53
  • DQMHistoTests: Total histograms compared: 4273241
  • DQMHistoTests: Total failures: 6
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 4273215
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 18848.904 KiB( 52 files compared)
  • DQMHistoSizes: changed ( 16834.0,... ): 3141.484 KiB HLT/ScoutingOffline
  • Checked 227 log files, 198 edm output root files, 53 DQM output files
  • TriggerResults: no differences found

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Pull request #49619 was updated. @Martin-Grunewald, @cmsbuild, @ctarricone, @gabrielmscampos, @mmusich, @nothingface0, @rseidita can you please check and sign again.

@mmusich
Copy link
Contributor

mmusich commented Dec 14, 2025

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

-1

Failed Tests: UnitTests
Size: This PR adds an extra 24KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-33e733/49968/summary.html
COMMIT: 6623b90
CMSSW: CMSSW_16_0_X_2025-12-14-0000/el8_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/49619/49968/install.sh to create a dev area with all the needed externals and cmssw changes.

Failed Unit Tests

I found 1 errors in the following unit tests:

---> test testMakeTrackValidationPlots had ERRORS

Comparison Summary

Summary:

  • You potentially added 203 lines to the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 5 differences found in the comparisons
  • Reco comparison had 4 failed jobs
  • DQMHistoTests: Total files compared: 53
  • DQMHistoTests: Total histograms compared: 4273241
  • DQMHistoTests: Total failures: 3
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 4273218
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 18848.904 KiB( 52 files compared)
  • DQMHistoSizes: changed ( 16834.0,... ): 3141.484 KiB HLT/ScoutingOffline
  • Checked 227 log files, 198 edm output root files, 53 DQM output files
  • TriggerResults: no differences found

@mmusich
Copy link
Contributor

mmusich commented Dec 14, 2025

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

+1

Size: This PR adds an extra 16KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-33e733/49970/summary.html
COMMIT: 6623b90
CMSSW: CMSSW_16_0_X_2025-12-14-0000/el8_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/49619/49970/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 202 lines to the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 5 differences found in the comparisons
  • Reco comparison had 4 failed jobs
  • DQMHistoTests: Total files compared: 53
  • DQMHistoTests: Total histograms compared: 4273241
  • DQMHistoTests: Total failures: 3
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 4273218
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 18848.904 KiB( 52 files compared)
  • DQMHistoSizes: changed ( 16834.0,... ): 3141.484 KiB HLT/ScoutingOffline
  • Checked 227 log files, 198 edm output root files, 53 DQM output files
  • TriggerResults: no differences found

@mmusich
Copy link
Contributor

mmusich commented Dec 15, 2025

+hlt

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants