Skip to content

L1-uGT emulator: fix to AXOL1TL's "Pt" inputs [15_1_X]#49781

Merged
cmsbuild merged 1 commit intocms-sw:CMSSW_15_1_Xfrom
missirol:fix_l1tGTAXOL1TLEtInputs2_151X
Jan 19, 2026
Merged

L1-uGT emulator: fix to AXOL1TL's "Pt" inputs [15_1_X]#49781
cmsbuild merged 1 commit intocms-sw:CMSSW_15_1_Xfrom
missirol:fix_l1tGTAXOL1TLEtInputs2_151X

Conversation

@missirol
Copy link
Contributor

backport of #49753

PR description:

From the description of #49753.

This PR fixes the "Pt" inputs used in the inference of AXOL1TL models in the L1-uGT emulation.

  • Without this PR, these "Pt" values are truncated to integers (which is unintended, as far as I understand).
  • With this PR, the data-emulator mismatches for L1T algorithms involving AXOL1TL (recently mentioned in #49056 (comment) are reduced by ~10x (see the validation section below).

This is a bugfix. It affects only the results of the L1-uGT emulation for AXOL1TL seeds.

PR validation:

None beyond the validation done for #49754.

If this PR is a backport, please specify the original PR and why you need to backport that PR. If this PR will be backported, please specify to which release cycle the backport is meant for:

#49753

Backport of a bugfix to the L1-uGT emulator, in case this CMSSW cycle is used for future Run-3 MC campaigns.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 12, 2026

A new Pull Request was created by @missirol for CMSSW_15_1_X.

It involves the following packages:

  • L1Trigger/L1TGlobal (l1)

@BenjaminRS, @cmsbuild, @quinnanm can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @mmusich this is something you requested to watch as well.
@ftenchini, @mandrenguyen, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 12, 2026

cms-bot internal usage

@missirol
Copy link
Contributor Author

type bugfix

@quinnanm
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

+1

Size: This PR adds an extra 20KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2767a3/50547/summary.html
COMMIT: f8dc1e6
CMSSW: CMSSW_15_1_X_2026-01-12-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/49781/50547/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 2 lines from the logs
  • Reco comparison results: 10 differences found in the comparisons
  • Reco comparison had 2 failed jobs
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 4124047
  • DQMHistoTests: Total failures: 57
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 4123970
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
  • Checked 215 log files, 184 edm output root files, 50 DQM output files
  • TriggerResults: found differences in 5 / 48 workflows

@quinnanm
Copy link
Contributor

+l1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_15_1_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_16_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @ftenchini, @sextonkennedy, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2)

@mandrenguyen
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 5b95860 into cms-sw:CMSSW_15_1_X Jan 19, 2026
8 checks passed
@missirol missirol deleted the fix_l1tGTAXOL1TLEtInputs2_151X branch January 29, 2026 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants