Draft
Conversation
ericonr
reviewed
Sep 4, 2023
Member
ericonr
left a comment
ericonr
left a comment
There was a problem hiding this comment.
Nothing release breaking here
henriquesimoes
force-pushed
the
pimega
branch
from
8c0adb0 to
899e723
Compare
ericonr
reviewed
Sep 12, 2023
henriquesimoes
force-pushed
the
pimega
branch
5 times, most recently
from
bf49151 to
944e2ae
Compare
henriquesimoes
force-pushed
the
pimega
branch
from
944e2ae to
b5623e4
Compare
henriquesimoes
force-pushed
the
pimega
branch
2 times, most recently
from
c9d8f7f to
1f80eba
Compare
henriquesimoes
force-pushed
the
pimega
branch
from
1f80eba to
7053062
Compare
henriquesimoes
force-pushed
the
pimega
branch
3 times, most recently
from
99d3cd6 to
7aaf29d
Compare
henriquesimoes
force-pushed
the
pimega
branch
from
7aaf29d to
88403ca
Compare
Pimega library is closed-source and its binaries and header files are thus installed from a tarball. Since it is an additional module to areaDetector, it is built in another file, making it possible to better reuse caching across base image (re)builds. pimegaIOC in `iocs` is currently used in deploy. Thus, it is build along with the support module. Its IOC RELEASE configuration specifies its path relatively to the AREA_DETECTOR module, making it (without a RELEASE patch) required to be in the areaDetector directory. $EPICS_RELEASE_FILE is used to configure the IOC analogously to the procedure in the IOC build. However, it is concatenated to the file, as the ADPIMEGA module is not yet in the list.
henriquesimoes
force-pushed
the
pimega
branch
from
88403ca to
39aeefb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These changes are using locally served packages, since nothing is available in the Internet.