Fix build errors and improve CI config #42
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
FWIW CI passes on my fork: https://github.com/rafbiels/SYCL-samples/actions/runs/13719491952 Will look into the container registry permissions in the meantime. |
rafbiels
force-pushed
the
fix-build
branch
8 times, most recently
from
9105b3f to
b9c9afc
Compare
* Fix -Wmissing-template-arg-list-after-template-kw compilation errors in nbody and fluid demos. * Fix sycl-ls regex in ConfigureSYCL.cmake following the removal of "ext_oneapi" from backend names. * Update ConfigureSYCL.cmake default CUDA and HIP arch to the oldest supported by oneAPI 2025.0. * Improve OpenMP CMake test in matrix_multiply_omp_compare sample. Previously it assumed all clang++ drivers support -fopenmp. This is only true in the oneAPI base toolkit version, but the open-source DPC++ nightly releases are built without libomp.so and linking with -fopenmp fails. Use try_compile to figure out if -fopenmp works. * Add a warning suppresion file to suppress CI build failures in external code from submodules. * Update the CI container with newer versions of CUDA and ROCm, and use a recent DPC++ open-source nightly instead of a oneAPI Toolkit release. * Restore CI workflow's permission to push containers to registry. * Do not push to registry in pull-request CI (not allowed in GitHub). Instead, push the image to a local registry and use that to build the code. Push to registry only in CI triggered by branch push.
DuncanMcBain
approved these changes
Mar 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-Wmissing-template-arg-list-after-template-kwcompilation errors in nbody and fluid demos.