-
-
Notifications
You must be signed in to change notification settings - Fork 282
refactor(git): code cleanup and test coverage #1417
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
afe52aa
to
aa57ab1
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1417 +/- ##
==========================================
+ Coverage 97.33% 97.59% +0.25%
==========================================
Files 42 57 +15
Lines 2104 2659 +555
==========================================
+ Hits 2048 2595 +547
- Misses 56 64 +8
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
aa57ab1
to
403febf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good cleanup, thanks!
For the f-string remark, I'll let @Lee-W decide
403febf
to
a3a5ca0
Compare
81f0034
to
08a1aa3
Compare
It seems that some lines are not covered before this PR change. I'll try to cover them. |
08a1aa3
to
5a7fad0
Compare
Just vibe tested the changes. |
214be08
to
d27ab71
Compare
cee142b
to
2a7e8ed
Compare
Finally passed codecov/patch check... |
5f0faae
to
9430778
Compare
9430778
to
1cc5858
Compare
I just split the changes into multiple PRs so it's easier to review. |
Description
EOLTypes
. I think it's unnecessary.map
.Checklist
Code Changes
poetry all
locally to ensure this change passes linter check and testsDocumentation Changes
poetry doc
locally to ensure the documentation pages renders correctlyExpected Behavior
Steps to Test This Pull Request
Additional Context