refactor(init): code cleanup and better test coverage #1424
Conversation
bearomorphism
force-pushed
the
refactor-init
branch
from
b3d3048 to
a36b7ef
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1424 +/- ##
==========================================
+ Coverage 97.33% 98.12% +0.78%
==========================================
Files 42 57 +15
Lines 2104 2661 +557
==========================================
+ Hits 2048 2611 +563
+ Misses 56 50 -6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
|
||
| commands.Init(config)() | ||
| check_cz_config(default_choice) | ||
| # check that config is not duplicated | ||
| check_pre_commit_config([cz_hook_config]) | ||
| check_pre_commit_config([CZ_HOOK_CONFIG]) | ||
|
|
||
|
|
||
| class TestNoPreCommitInstalled: |
There was a problem hiding this comment.
test_pre_commit_not_installed is not working as expected...
| "update_changelog_on_bump = true\n" | ||
| "major_version_zero = true\n" | ||
| 'version = "0.0.1"\n' |
There was a problem hiding this comment.
Does the order of these configs matter here?
| if not tag_format: | ||
| tag_format = default_format | ||
| return tag_format | ||
| return tag_format or default_format | ||
|
|
||
| def _ask_version_provider(self) -> str: | ||
| """Ask for setting: version_provider""" | ||
|
|
||
| OPTS = { |
There was a problem hiding this comment.
Ideally, the VersionProvider ABC class should include identifier and description. Which would allow us to do something like
providers = metadata.entry_points(group=PROVIDER_ENTRYPOINT)
{provider.identifier: provider.description for provider in providers} This way, custom user made providers would also appear in the init functions.
Just to be clear, this is optional, I hardcoded them here because it would help 90% of the users and I didn't want to go further.
Description
Checklist
Code Changes
poetry alllocally to ensure this change passes linter check and testsDocumentation Changes
poetry doclocally to ensure the documentation pages renders correctlyExpected Behavior
Steps to Test This Pull Request
Additional Context