Skip to content

[DX-2968], added support for CSLP tags #94

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: development
Choose a base branch
from

Conversation

naman-contentstack
Copy link
Contributor

Minor version bump 3.2.0 -> 3.3.0

@naman-contentstack naman-contentstack self-assigned this Jun 10, 2025
@naman-contentstack naman-contentstack requested a review from a team as a code owner June 10, 2025 19:19
@aman19K aman19K requested a review from Copilot June 11, 2025 05:37
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Adds support for editable CSLP tags throughout type generation and bumps the version to 3.3.0.

  • Introduce isEditableTags flag to all relevant generation configs
  • Emit a new CSLPAttribute interface and $ field mappings when isEditableTags is enabled
  • Update integration tests for editable fields and bump package version

Reviewed Changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
tests/integration/generateTS/generateTS.test.ts Added a new integration test to verify CSLP tag output
src/types/index.ts Added isEditableTags option to GenerateTSBase and related types
src/generateTS/stack/builtins.ts Updated defaultInterfaces to include CSLPAttribute when flag is set
src/generateTS/index.ts Propagated isEditableTags through generateTS and generateTSFromContentTypes
src/generateTS/factory.ts Extended visit_fields to generate $ mappings for editable tags
package.json Bumped version from 3.2.0 to 3.3.0
.talismanrc Updated ignore list for new files
Comments suppressed due to low confidence (2)

tests/integration/generateTS/generateTS.test.ts:96

  • Add a negative test case to verify that when isEditableTags is false, the output does not include the CSLPAttribute interface or the $?: mapping.
it("generates type definitions with editable fields", async () => {

src/types/index.ts:24

  • [nitpick] Add a JSDoc comment explaining the purpose of the isEditableTags option to make the API more self-documenting.
  isEditableTags?: boolean;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants