Refactor MultiGridAssembler and RegionalAnalysisController#963
Closed
trevorgerhardt wants to merge 10 commits intodevfrom
Closed
Refactor MultiGridAssembler and RegionalAnalysisController#963trevorgerhardt wants to merge 10 commits intodevfrom
trevorgerhardt wants to merge 10 commits intodevfrom
Conversation
trevorgerhardt
force-pushed
the
refactor-results-writers-filestorage
branch
from
cbadb22 to
d4f16d0
Compare
Organize components to more cleanly handle the creation, validation, and writing of all the distinct formats we now handle.
In a new machine setup I get the following build errors with the type casting. Removing the casting fixes the errors. `Cannot cast from GeneratedMessageLite.Builder<GeneratedMessageLite<GeneratedMessageLite<MessageType,GeneratedMessageLite.Builder<MessageType,BuilderType>>,GeneratedMessageLite.Builder<GeneratedMessageLite<MessageType,BuilderType>,BuilderType>>,GeneratedMessageLite.Builder<GeneratedMessageLite<GeneratedMessageLite<MessageType,BuilderType>,BuilderType>,BuilderType>> to Geobuf.Data.Feature.Builder`
trevorgerhardt
force-pushed
the
refactor-results-writers-filestorage
branch
from
0360aba to
949644d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Organize components to more cleanly handle the creation, validation, and writing of all the distinct formats we now handle.