Skip to content

#957 fix stop process by port #1008

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 21, 2024
Merged

Conversation

scholarsmate
Copy link
Member

Getting the PID for services listening on a given port appears unreliable so try using lsof, and fall-back to using the portToPid function in pid-port if 'lsof` fails.

Fixes #957.

@scholarsmate scholarsmate added bug Something isn't working client javascript labels Oct 15, 2024
@scholarsmate scholarsmate added this to the v1.0.0 milestone Oct 15, 2024
@scholarsmate scholarsmate self-assigned this Oct 15, 2024
@scholarsmate scholarsmate force-pushed the 957/fix_stop_process_by_port branch from 8c3ea42 to 6b9fc04 Compare October 15, 2024 20:33
@scholarsmate scholarsmate force-pushed the 957/fix_stop_process_by_port branch from b5e1a13 to b392a8b Compare October 15, 2024 20:39
@scholarsmate scholarsmate force-pushed the 957/fix_stop_process_by_port branch from 7db96a8 to 1e29c73 Compare October 21, 2024 13:51
@scholarsmate scholarsmate merged commit 70e71dd into main Oct 21, 2024
16 checks passed
@scholarsmate scholarsmate deleted the 957/fix_stop_process_by_port branch October 21, 2024 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working client javascript
Projects
Development

Successfully merging this pull request may close these issues.

stopProcessUsingPID(...) returns false when OE server stops
1 participant