fix: harden core C library for security, correctness, and code quality by scholarsmate · Pull Request #1302 · ctc-oss/omega-edit

scholarsmate · 2026-03-06T20:24:55Z

Security and correctness fixes:

Fix snprintf buffer overflow in edit.cpp (FILENAME_MAX -> FILENAME_MAX + 1)
Convert recursive undo/redo to iterative loops to prevent stack overflow
Add thread_local to static buffers in filesystem.cpp for thread safety
Add odd-length input validation to omega_encode_hex2bin
Guard DEBUG define with #ifndef to support conditional compilation
Remove unsafe mkstemp assert in filesystem.cpp

Design and code quality fixes:

Replace assert() with proper error returns in all public API functions across segment, change, search, viewport, session, check, utility, and filesystem modules
Replace magic number 7 with sizeof(omega_data_t) - 1 in segment.cpp
Fix DBG macro parenthesization in macros.h
Rename stl_string_adapter.cpp to stl_string_adaptor.cpp to match header
Add negative capacity guard in segment creation

Test coverage:

Add Hex2Bin Odd Length test (7 assertions)
Add Large Transaction Undo/Redo test (114 assertions)
Add Null Pointer Safety test for core APIs (53 assertions)
Add Null Pointer Safety test for utility APIs (14 assertions)
Add Null Pointer Safety test for filesystem APIs (11 assertions)
Add Segment Small Data Optimization test (11 assertions)

Security and correctness fixes: - Fix snprintf buffer overflow in edit.cpp (FILENAME_MAX -> FILENAME_MAX + 1) - Convert recursive undo/redo to iterative loops to prevent stack overflow - Add thread_local to static buffers in filesystem.cpp for thread safety - Add odd-length input validation to omega_encode_hex2bin - Guard DEBUG define with #ifndef to support conditional compilation - Remove unsafe mkstemp assert in filesystem.cpp Design and code quality fixes: - Replace assert() with proper error returns in all public API functions across segment, change, search, viewport, session, check, utility, and filesystem modules - Replace magic number 7 with sizeof(omega_data_t) - 1 in segment.cpp - Fix DBG macro parenthesization in macros.h - Rename stl_string_adapter.cpp to stl_string_adaptor.cpp to match header - Add negative capacity guard in segment creation Test coverage: - Add Hex2Bin Odd Length test (7 assertions) - Add Large Transaction Undo/Redo test (114 assertions) - Add Null Pointer Safety test for core APIs (53 assertions) - Add Null Pointer Safety test for utility APIs (14 assertions) - Add Null Pointer Safety test for filesystem APIs (11 assertions) - Add Segment Small Data Optimization test (11 assertions)

Copilot

Pull request overview

This PR hardens the Ωedit core library’s C/C++ APIs against common correctness and security issues (null-pointer handling, bounds checks, stack safety, thread safety), and expands the core test suite to validate these behaviors.

Changes:

Replace a number of assert()-based preconditions in public APIs with defensive checks + error returns.
Convert undo/redo transaction processing to iterative loops to avoid recursion-driven stack overflows.
Add targeted tests for odd-length hex decoding, large transaction undo/redo, segment SDO behavior, and null-pointer safety across multiple modules.

Reviewed changes

Copilot reviewed 18 out of 19 changed files in this pull request and generated 5 comments.

Show a summary per file

File	Description
core/src/lib/edit.cpp	Adjusts temp/checkpoint filename buffers; converts undo/redo to iterative loops.
core/src/lib/filesystem.cpp	Adds `thread_local` buffers and replaces some asserts with runtime validation.
core/src/lib/search.cpp	Adds runtime input validation for search context creation and getters.
core/src/lib/segment.cpp	Adds negative-capacity guard and replaces magic threshold with `sizeof(omega_data_t) - 1`.
core/src/lib/session.cpp	Replaces many `assert(session_ptr)` preconditions with null-safe return values.
core/src/lib/viewport.cpp	Makes viewport getters/setters null-safe (returning defaults).
core/src/lib/utility.c	Adds null/arg validation and improved error handling for utility helpers.
core/src/lib/encode.c	Adds odd-length hex input validation.
core/src/lib/impl_/macros.h	Fixes `DBG(x)` macro parenthesization.
core/src/lib/check.cpp	Makes `omega_check_model` null-safe.
core/src/lib/change.cpp	Makes change getters null-safe.
core/src/lib/stl_string_adaptor.cpp	Introduces/renames STL string adaptor implementation.
core/src/include/omega_edit/config.h	Stops unconditionally defining `DEBUG` in the public header.
core/CMakeLists.txt	Defines `DEBUG` in Debug builds via CMake compile definitions.
core/src/tests/session_tests.cpp	Adds large-transaction undo/redo test and broad null-safety test coverage.
core/src/tests/omegaEdit_tests.cpp	Adds segment small-data-optimization tests (incl. negative capacity).
core/src/tests/utility_tests.cpp	Adds utility null-pointer safety tests.
core/src/tests/filesystem_tests.cpp	Adds filesystem null-pointer safety tests.
core/src/tests/encode_tests.cpp	Adds odd-length hex2bin tests.

Copilot · 2026-03-06T20:33:39Z

core/src/lib/encode.c

 size_t omega_encode_hex2bin(const char *src, omega_byte_t *dst, size_t src_length) {
    assert(src);
    assert(dst);
+    if (src_length & 1) {
+        /* Odd-length hex string is invalid */
+        return 0;
+    }


omega_encode_hex2bin() still relies on assert(src) / assert(dst) and writes a null terminator to dst (dst[i] = '\0'), but encode.h documents dst as needing only (src_length / 2) bytes. This combination can lead to out-of-bounds writes or null dereferences in release builds; either stop writing the terminator or update the API contract and add runtime null checks that return 0 on invalid inputs.

Copilot · 2026-03-06T20:33:40Z

core/src/lib/search.cpp

+    if (!session_ptr || !pattern || session_offset < 0) { return nullptr; }
    pattern_length =
            pattern_length ? pattern_length : static_cast<int64_t>(strlen(reinterpret_cast<const char *>(pattern)));
    assert(0 < pattern_length);


omega_search_create_context_bytes() still has an assert(0 < pattern_length) after deriving pattern_length via strlen(). With an empty pattern this will abort in Debug builds (and may behave unexpectedly in Release); consider returning nullptr when pattern_length <= 0 instead of asserting, consistent with the other new input validation in this function.

Suggested change

assert(0 < pattern_length);

if (pattern_length <= 0) { return nullptr; }

Copilot · 2026-03-06T20:33:40Z

core/src/lib/edit.cpp

 int64_t omega_edit_undo_last_change(omega_session_t *session_ptr) {
-    if ((omega_session_changes_paused(session_ptr) == 0) && !session_ptr->models_.back()->changes.empty()) {
+    int64_t result = 0;
+    while ((omega_session_changes_paused(session_ptr) == 0) && !session_ptr->models_.back()->changes.empty()) {
        const auto change_ptr = session_ptr->models_.back()->changes.back();
        session_ptr->models_.back()->changes.pop_back();


omega_edit_undo_last_change() now dereferences session_ptr->models_ inside the loop without validating session_ptr first. Because omega_session_changes_paused(nullptr) returns 0, passing a null session can enter the loop and crash; add an early guard (e.g., return 0 or -1) before accessing session_ptr internals.

Copilot · 2026-03-06T20:33:40Z

core/src/lib/edit.cpp

-    if ((omega_session_changes_paused(session_ptr) == 0) && !session_ptr->models_.back()->changes_undone.empty()) {
+    while ((omega_session_changes_paused(session_ptr) == 0) && !session_ptr->models_.back()->changes_undone.empty()) {
        const auto change_ptr = session_ptr->models_.back()->changes_undone.back();
        rc = update_(session_ptr, change_ptr);


omega_edit_redo_last_undo() continues looping even if update_() fails (rc < 0), potentially partially redoing a transaction after an error. Consider breaking/returning immediately on rc < 0 so callers get a clear failure signal and the session isn't advanced further in an error state.

Suggested change

rc = update_(session_ptr, change_ptr);

rc = update_(session_ptr, change_ptr);

if (rc < 0) {

// On failure, stop redoing and return the error without modifying the undo stack further

return rc;

}

Copilot · 2026-03-06T20:33:41Z

core/src/lib/filesystem.cpp

 char *omega_util_dirname(char const *path, char *buffer) {
-    assert(path);
-    static char buff[FILENAME_MAX]{};//create string buffer to hold path
+    if (!path || !*path) { return nullptr; }
+    static thread_local char buff[FILENAME_MAX]{};
    if (!buffer) { buffer = buff; }
    auto const dirname_str = fs::path(path).parent_path().string();
-    assert(0 <= dirname_str.length());
-    assert(FILENAME_MAX > dirname_str.length());
+    if (dirname_str.length() >= FILENAME_MAX) { return nullptr; }
    auto const len = dirname_str.copy(buffer, dirname_str.length());


omega_util_dirname() can now return nullptr for valid-but-too-long paths. Callers in this file (e.g., omega_util_available_filename builds std::string from omega_util_dirname/omega_util_basename results) assume a non-null C-string, so this change can turn an oversize path into UB/crashes. Update those callers to handle nullptr returns (or provide a safe non-null fallback string) to match the new contract.

scholarsmate · 2026-03-06T21:16:17Z

@copilot open a new pull request to apply changes based on the comments in this thread

Copilot · 2026-03-06T21:16:24Z

@scholarsmate I've opened a new pull request, #1303, to work on those changes. Once the pull request is ready, I'll request review from you.

Copilot

Pull request overview

Copilot reviewed 18 out of 19 changed files in this pull request and generated 3 comments.

Copilot · 2026-03-06T21:21:51Z

core/src/lib/utility.c

 int omega_util_strnicmp(const char *s1, const char *s2, uint64_t sz) {
+    if (!s1 || !s2) { return s1 == s2 ? 0 : (s1 ? 1 : -1); }
    int rc = 0;
    for (uint64_t i = 0; i < sz; ++i) { if (0 != (rc = tolower(s1[i]) - tolower(s2[i]))) break; }


tolower() is undefined for negative char values (common when char is signed and bytes are >= 0x80). Cast to unsigned char before calling tolower (and similarly for any other ctype.h calls) to avoid UB when comparing non-ASCII data.

Suggested change

for (uint64_t i = 0; i < sz; ++i) { if (0 != (rc = tolower(s1[i]) - tolower(s2[i]))) break; }

for (uint64_t i = 0; i < sz; ++i) {

if (0 != (rc = tolower((unsigned char) s1[i]) - tolower((unsigned char) s2[i]))) break;

}

Copilot · 2026-03-06T21:21:51Z

core/src/lib/edit.cpp

    if (FILENAME_MAX <= snprintf(checkpoint_filename, FILENAME_MAX, "%s%c.OmegaEdit-chk.%zu.XXXXXX",
                                 checkpoint_directory, omega_util_directory_separator(), session_ptr->models_.size())) {


The buffer was increased to FILENAME_MAX + 1, but snprintf still uses FILENAME_MAX as the size argument and comparison threshold. Use the actual buffer size (e.g., sizeof(checkpoint_filename)) for both the snprintf size parameter and truncation check so the code is self-consistent and won’t regress if the buffer size changes again.

Suggested change

if (FILENAME_MAX <= snprintf(checkpoint_filename, FILENAME_MAX, "%s%c.OmegaEdit-chk.%zu.XXXXXX",

checkpoint_directory, omega_util_directory_separator(), session_ptr->models_.size())) {

const auto snprintf_result = snprintf(checkpoint_filename, sizeof(checkpoint_filename),

"%s%c.OmegaEdit-chk.%zu.XXXXXX", checkpoint_directory,

omega_util_directory_separator(), session_ptr->models_.size());

if (snprintf_result < 0 || static_cast<size_t>(snprintf_result) >= sizeof(checkpoint_filename)) {

Copilot · 2026-03-06T21:21:52Z

core/src/include/omega_edit/config.h

 /** Define to enable debugging */
-#define DEBUG
+#ifndef DEBUG
+/* DEBUG should be set by the build system (e.g., -DDEBUG in CMake Debug builds) */
+#endif


This comment block is now misleading: it says “Define to enable debugging” but the header no longer defines DEBUG, and the #ifndef DEBUG block has no effect other than a comment. Consider rewriting this section to clearly state that DEBUG is not defined by the public header and must be provided by the build system (or remove the empty conditional entirely).

* Initial plan * fix: address review comments - null checks, error handling, nullptr guards Co-authored-by: scholarsmate <2205472+scholarsmate@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: scholarsmate <2205472+scholarsmate@users.noreply.github.com>

Copilot

Pull request overview

Copilot reviewed 19 out of 20 changed files in this pull request and generated 2 comments.

Copilot · 2026-03-06T22:05:29Z

core/src/lib/edit.cpp

        return -1;
    }
-    char temp_filename[FILENAME_MAX];
+    char temp_filename[FILENAME_MAX + 1];


temp_filename was expanded to FILENAME_MAX + 1, but later in this function snprintf still uses FILENAME_MAX as its size argument and the truncation check compares against FILENAME_MAX. That combination can still incorrectly treat a just-fitting path as truncated (and doesn’t actually take advantage of the extra byte). Use sizeof(temp_filename) consistently for snprintf and truncation checks, and ensure temp_filename is initialized/validated before any reads in case omega_util_dirname()/omega_util_get_current_dir() fail and leave it unwritten.

Suggested change

char temp_filename[FILENAME_MAX + 1];

char temp_filename[FILENAME_MAX];

temp_filename[0] = '\0';

Copilot · 2026-03-06T22:05:30Z

core/src/lib/edit.cpp

+    char checkpoint_filename[FILENAME_MAX + 1];
    if (FILENAME_MAX <= snprintf(checkpoint_filename, FILENAME_MAX, "%s%c.OmegaEdit-chk.%zu.XXXXXX",
                                 checkpoint_directory, omega_util_directory_separator(), session_ptr->models_.size())) {
        LOG_ERROR("failed to create checkpoint filename template");


checkpoint_filename is FILENAME_MAX + 1, but snprintf is called with FILENAME_MAX and the truncation check uses FILENAME_MAX. This can spuriously fail for templates that would fit in the allocated buffer. Pass sizeof(checkpoint_filename) to snprintf and update the truncation check accordingly.

…pe assertions in coverageGaps.spec.ts

Some client functions reject with string errors (getComputedFileSize, destroySession) while others reject with Error objects (insert, del). Use expect(err).to.exist to accept both types.

Copilot

Pull request overview

Copilot reviewed 34 out of 35 changed files in this pull request and generated 7 comments.

Copilot · 2026-03-07T05:03:16Z

core/src/lib/filesystem.cpp

    auto const absolute_path_str = fs::absolute(fs::canonical(path)).string();
-    assert(0 < absolute_path_str.length());
-    assert(FILENAME_MAX > absolute_path_str.length());
+    if (absolute_path_str.empty() || absolute_path_str.length() >= FILENAME_MAX) { return nullptr; }
    auto const len = absolute_path_str.copy(buffer, absolute_path_str.length());


omega_util_normalize_path() calls std::filesystem::canonical() / absolute() which can throw (nonexistent path, permission issues). Wrap this in a try/catch for std::filesystem::filesystem_error and return nullptr (optionally log) instead of letting an exception terminate the process.

Copilot · 2026-03-07T05:03:17Z

packages/client/tests/specs/coverageGaps.spec.ts

+      const session1 = await createSession()
+      const session1_id = session1.getSessionId()
+      const session2 = await createSession()
+      const session2_id = session2.getSessionId()
+      expect(await getSessionCount()).to.equal(2)


This test assumes the global session count is exactly 2 after creating two sessions. If any other spec leaks a session (or a previous test in this file fails before cleanup), this becomes flaky. Consider asserting the initial count is 0 (or checking that the count increased by 2) before the expect(...).to.equal(2) assertion.

Copilot · 2026-03-07T05:03:17Z

core/src/lib/edit.cpp

-    assert(session_ptr);
-    assert(file_path);
-    assert(0 <= offset);
+    if (!session_ptr || !file_path || offset < 0) { return -1; }


omega_edit_save_segment() checks file_path != nullptr but not that it’s non-empty. Downstream calls (e.g., omega_util_dirname) now treat empty paths as invalid and may return nullptr, which can lead to undefined behavior. Add a !*file_path guard up front (and consider validating saved_file_path buffer expectations too).

Suggested change

if (!session_ptr || !file_path || offset < 0) { return -1; }

if (!session_ptr || !file_path || !*file_path || offset < 0) { return -1; }

Copilot · 2026-03-07T05:03:17Z

core/src/lib/visit.cpp

 int omega_visit_changes(const omega_session_t *session_ptr, omega_session_change_visitor_cbk_t cbk, void *user_data) {
-    assert(session_ptr);
+    if (!session_ptr) { return -1; }
    int rc = 0;
    for (const auto &iter: session_ptr->models_.back()->changes) {
        if ((rc = cbk(iter.get(), user_data)) != 0) { break; }


omega_visit_changes*() now checks session_ptr but still unconditionally calls cbk(...). If a caller passes a null visitor callback, this will segfault. Add a if (!cbk) return -1; (or 0, depending on the API contract) similar to the session_ptr guard.

Copilot · 2026-03-07T05:03:17Z

core/src/lib/edit.cpp

+        LOG_ERROR("failed to create checkpoint filename template");
+        return -1;
+    }
+    const auto checkpoint_fd = omega_util_mkstemp(checkpoint_filename, 0600);// S_IRUSR | S_IWUSR


omega_util_mkstemp() return value isn’t checked before close(). If mkstemp fails, the filename template still contains XXXXXX and the code will continue, potentially creating/writing a non-unique checkpoint path. Check checkpoint_fd < 0 and return an error (only close when checkpoint_fd >= 0).

Suggested change

const auto checkpoint_fd = omega_util_mkstemp(checkpoint_filename, 0600);// S_IRUSR | S_IWUSR

const auto checkpoint_fd = omega_util_mkstemp(checkpoint_filename, 0600);// S_IRUSR | S_IWUSR

if (checkpoint_fd < 0) {

LOG_ERROR("omega_util_mkstemp failed for checkpoint file '" << checkpoint_filename << "'");

return -1;

}

Copilot · 2026-03-07T05:03:18Z

core/src/lib/edit.cpp

    const auto *const checkpoint_directory = omega_session_get_checkpoint_directory(session_ptr);
    // make sure the checkpoint directory exists
    if (omega_util_directory_exists(checkpoint_directory) == 0) {
        LOG_ERROR("checkpoint directory '" << checkpoint_directory << "' does not exist");


If the checkpoint directory doesn’t exist, omega_edit_create_checkpoint() logs an error but continues. This likely leads to mkstemp/open failures later; it should return -1 immediately when omega_util_directory_exists() is false.

Suggested change

LOG_ERROR("checkpoint directory '" << checkpoint_directory << "' does not exist");

LOG_ERROR("checkpoint directory '" << checkpoint_directory << "' does not exist");

return -1;

Copilot · 2026-03-07T05:03:18Z

core/src/lib/edit.cpp

+    char checkpoint_filename[FILENAME_MAX + 1];
    if (FILENAME_MAX <= snprintf(checkpoint_filename, FILENAME_MAX, "%s%c.OmegaEdit-chk.%zu.XXXXXX",
                                 checkpoint_directory, omega_util_directory_separator(), session_ptr->models_.size())) {
        LOG_ERROR("failed to create checkpoint filename template");


The checkpoint template creation is guarded by snprintf, but the subsequent omega_util_mkstemp(checkpoint_filename, ...) result must be checked for failure before calling close() and continuing; otherwise the XXXXXX template may remain unresolved and a non-unique/invalid checkpoint path can be used.

scholarsmate · 2026-03-07T05:06:10Z

@copilot open a new pull request to apply changes based on the comments in this thread

Copilot · 2026-03-07T05:06:17Z

@scholarsmate I've opened a new pull request, #1304, to work on those changes. Once the pull request is ready, I'll request review from you.

…s (round 4) (#1304) * Initial plan * fix: address review comments from PR 1302 review 3907448840 Co-authored-by: scholarsmate <2205472+scholarsmate@users.noreply.github.com> * fix: improve snprintf checks with explicit result variable and dual condition Co-authored-by: scholarsmate <2205472+scholarsmate@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: scholarsmate <2205472+scholarsmate@users.noreply.github.com>

scholarsmate requested a review from Copilot March 6, 2026 20:25

Copilot started reviewing on behalf of scholarsmate March 6, 2026 20:27 View session

Copilot AI reviewed Mar 6, 2026

View reviewed changes

scholarsmate requested a review from Copilot March 6, 2026 21:15

Copilot AI mentioned this pull request Mar 6, 2026

fix: address review comments on core library hardening #1303

Merged

Copilot started reviewing on behalf of scholarsmate March 6, 2026 21:20 View session

Copilot AI reviewed Mar 6, 2026

View reviewed changes

scholarsmate requested a review from Copilot March 6, 2026 21:57

Copilot started reviewing on behalf of scholarsmate March 6, 2026 21:58 View session

Copilot AI reviewed Mar 6, 2026

View reviewed changes

scholarsmate added 6 commits March 6, 2026 17:25

applied fixes

e455483

applied fixes

eca1b30

optimize undo a bit

a44bde2

optimize transforms a bit, eliminating ~1/3 of the I/O

2540bde

two low-risk performance optimzations

26539f0

three additional low-risk performance optimzations

147967b

scholarsmate force-pushed the fix/core-security-and-quality branch 3 times, most recently from 607236f to 6b7d96d Compare March 7, 2026 04:20

close testing gaps

5fb8a75

scholarsmate force-pushed the fix/core-security-and-quality branch from 6b7d96d to 5fb8a75 Compare March 7, 2026 04:24

scholarsmate added 2 commits March 6, 2026 23:35

fix: replace dynamic ESM imports with static imports and fix error ty…

496f5b3

…pe assertions in coverageGaps.spec.ts

fix: use type-agnostic error assertions in coverageGaps.spec.ts

5399e02

Some client functions reject with string errors (getComputedFileSize, destroySession) while others reject with Error objects (insert, del). Use expect(err).to.exist to accept both types.

scholarsmate requested a review from Copilot March 7, 2026 04:52

Copilot started reviewing on behalf of scholarsmate March 7, 2026 04:56 View session

Copilot AI reviewed Mar 7, 2026

View reviewed changes

Copilot AI mentioned this pull request Mar 7, 2026

fix: harden core C library against remaining review-identified defects (round 4) #1304

Merged

Copilot AI and others added 4 commits March 7, 2026 00:16

fix: harden core save and client edit paths

efd6708

fix: refresh native server for client tests

e92d0b0

fix: define O_BINARY for non-Windows builds

2051bd4

scholarsmate merged commit b864e0c into main Mar 7, 2026
37 checks passed

scholarsmate deleted the fix/core-security-and-quality branch March 7, 2026 13:47

	assert(0 < pattern_length);
	if (pattern_length <= 0) { return nullptr; }

-        rc = update_(session_ptr, change_ptr);
+        rc = update_(session_ptr, change_ptr);
+        if (rc < 0) {
+            // On failure, stop redoing and return the error without modifying the undo stack further
+            return rc;
+        }

		if (FILENAME_MAX <= snprintf(checkpoint_filename, FILENAME_MAX, "%s%c.OmegaEdit-chk.%zu.XXXXXX",
		checkpoint_directory, omega_util_directory_separator(), session_ptr->models_.size())) {

-    if (FILENAME_MAX <= snprintf(checkpoint_filename, FILENAME_MAX, "%s%c.OmegaEdit-chk.%zu.XXXXXX",
-                                 checkpoint_directory, omega_util_directory_separator(), session_ptr->models_.size())) {
+    const auto snprintf_result = snprintf(checkpoint_filename, sizeof(checkpoint_filename),
+                                          "%s%c.OmegaEdit-chk.%zu.XXXXXX", checkpoint_directory,
+                                          omega_util_directory_separator(), session_ptr->models_.size());
+    if (snprintf_result < 0 || static_cast<size_t>(snprintf_result) >= sizeof(checkpoint_filename)) {

	char temp_filename[FILENAME_MAX + 1];
	char temp_filename[FILENAME_MAX];
	temp_filename[0] = '\0';

	if (!session_ptr \|\| !file_path \|\| offset < 0) { return -1; }
	if (!session_ptr \|\| !file_path \|\| !*file_path \|\| offset < 0) { return -1; }

	LOG_ERROR("checkpoint directory '" << checkpoint_directory << "' does not exist");
	LOG_ERROR("checkpoint directory '" << checkpoint_directory << "' does not exist");
	return -1;

Conversation

scholarsmate commented Mar 6, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Mar 6, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 6, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 6, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 6, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 6, 2026

Choose a reason for hiding this comment

Uh oh!

scholarsmate commented Mar 6, 2026

Uh oh!

Copilot AI commented Mar 6, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Mar 6, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 6, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 6, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Mar 6, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 6, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Mar 7, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 7, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 7, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 7, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 7, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 7, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 7, 2026

Choose a reason for hiding this comment

Uh oh!

scholarsmate commented Mar 7, 2026

Uh oh!

Copilot AI commented Mar 7, 2026

Uh oh!

Uh oh!