Merged
Conversation
Collaborator
|
Can one of the admins verify this patch? |
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #147 +/- ##
==========================================
+ Coverage 86.09% 86.41% +0.32%
==========================================
Files 139 145 +6
Lines 15357 16067 +710
Branches 2232 2297 +65
==========================================
+ Hits 13221 13884 +663
- Misses 1493 1517 +24
- Partials 643 666 +23
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Kritika-Bhateja-03
previously approved these changes
Jan 28, 2025
Saksham-Nautiyal
previously approved these changes
Jan 28, 2025
8d1d200
sachin-apa
approved these changes
Feb 3, 2025
Contributor
sachin-apa
left a comment
There was a problem hiding this comment.
Approved as the Integration tests are passing for the modules on the changes done
Saksham-Nautiyal
approved these changes
Feb 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adding UTs for snapshot module to improve coverage.
Checklist:
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration