-
Notifications
You must be signed in to change notification settings - Fork 23
Mock the actual behavior of fail_json #173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #173 +/- ##
==========================================
- Coverage 90.54% 90.24% -0.30%
==========================================
Files 145 143 -2
Lines 16695 16541 -154
Branches 2367 2365 -2
==========================================
- Hits 15116 14928 -188
- Misses 920 942 +22
- Partials 659 671 +12
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
dcac950
to
344be16
Compare
As per the Codecov report, it brings missing and partial.. |
After adopting the same behavior as fail_json, some UTs coverage indeed went down, because the previous FailJsonException is caught and thrown to upper method caller. |
It is not the module code coverage, but the test case code coverage which is weired. |
For codecov app, the stats are weird indeed. Maybe we can adopt a more reasonable way to calculate the coverage in future. |
5b4c995
to
02f4791
Compare
Ansible faile_json will call sys.exit, then abort the execution, but currently we use FailJsonException to mock fail_json, that it cannot abort the execution. Now mock fail_json to throw SystemExit to align with Ansible behavior. All UTs are updated to extend PowerScaleUnitBase.
02f4791
to
bfe8972
Compare
Good catch. It is my fault. Used wrong indentation. Please recheck the result. |
Ansible faile_json will call sys.exit, then abort the execution, but currently we use FailJsonException to mock fail_json, that it cannot abort the execution.
Now mock fail_json to throw SystemExit to align with Ansible behavior.
All UTs are updated to extend PowerScaleUnitBase.
Description
A few sentences describing the overall goals of the pull request's commits.
GitHub Issues
List the GitHub issues impacted by this PR:
Checklist:
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration