Skip to content

GH issue #181: Updating Examples playbooks for NetworkPool Module #182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 21, 2025

Conversation

Bhavneet-Sharma
Copy link
Contributor

@Bhavneet-Sharma Bhavneet-Sharma commented May 20, 2025

Description

Updating Examples playbooks for NetworkPool Module

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
#181

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, pep8, linting, or security issues
  • I have performed Ansible Sanity test using --docker default
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Backward compatibility is not broken

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Unit Test

@codecov-commenter
Copy link

codecov-commenter commented May 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.25%. Comparing base (e4ae620) to head (cfe0707).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #182   +/-   ##
=======================================
  Coverage   90.25%   90.25%           
=======================================
  Files         143      143           
  Lines       16544    16544           
  Branches     2365     2365           
=======================================
  Hits        14931    14931           
  Misses        942      942           
  Partials      671      671           
Flag Coverage Δ
units 90.25% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@gokul-srivathsan gokul-srivathsan self-requested a review May 20, 2025 10:33
Copy link

@gokul-srivathsan gokul-srivathsan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@meenakshidembi691
Copy link
Contributor

Please check if changes are required in playbook also.

@Bhavneet-Sharma Bhavneet-Sharma merged commit b7d1c28 into main May 21, 2025
19 checks passed
@Bhavneet-Sharma Bhavneet-Sharma deleted the usr/Bhavneet-Sharma/pool_pb_update branch May 21, 2025 05:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants