Skip to content

Remove ansible 2.15 from workflow and add python 3.12 #189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 12, 2025

Conversation

P-Cao
Copy link
Contributor

@P-Cao P-Cao commented Jun 12, 2025

Description

Due to failures in UT process, remove Ansible 2.15 which is not in support matrix from workflow combination
Add python 312 for workflow

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, pep8, linting, or security issues
  • I have performed Ansible Sanity test using --docker default
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Backward compatibility is not broken

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Test A
  • Test B

@codecov-commenter
Copy link

codecov-commenter commented Jun 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.27%. Comparing base (cd646cb) to head (babbdd9).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #189   +/-   ##
=======================================
  Coverage   90.27%   90.27%           
=======================================
  Files         143      143           
  Lines       16553    16553           
  Branches     2365     2365           
=======================================
  Hits        14944    14944           
  Misses        941      941           
  Partials      668      668           
Flag Coverage Δ
units 90.27% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

forrestxia
forrestxia previously approved these changes Jun 12, 2025
@P-Cao
Copy link
Contributor Author

P-Cao commented Jun 12, 2025

@forrestxia Lint job now is updated to ansible-lint. So the required check does not apply. It should be Okay after this PR is merged and workflow is updated.

@forrestxia forrestxia merged commit fee6175 into main Jun 12, 2025
44 checks passed
@forrestxia forrestxia deleted the usr/p_cao/update-workflow-remove-a215-add-p312 branch June 12, 2025 06:39
forrestxia pushed a commit that referenced this pull request Jun 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants