Update python SDK version and Fix info module #190
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Luis Liu <[email protected]>
vangork
requested review from
Bhavneet-Sharma,
meenakshidembi691,
trisha-dell,
forrestxia,
baoy1,
taohe1012,
P-Cao,
tanh17 and
RayLiu7
as code owners
vangork
changed the title
Signed-off-by: Luis Liu <[email protected]>
Signed-off-by: Luis Liu <[email protected]>
Signed-off-by: Luis Liu <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #190 +/- ##
==========================================
- Coverage 90.28% 90.27% -0.02%
==========================================
Files 143 143
Lines 16567 16594 +27
Branches 2365 2367 +2
==========================================
+ Hits 14958 14980 +22
- Misses 941 945 +4
- Partials 668 669 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
baoy1
reviewed
Jun 13, 2025
| @@ -4003,6 +4003,13 @@ def get_support_assist_settings(self): | |||
| else: | |||
| return {} | |||
|
|
|||
| def get_maintenance_settings(self): | |||
There was a problem hiding this comment.
Would UT be updated to cover the change?
There was a problem hiding this comment.
This is partially covered. Is it possible to add test for utils.isi_sdk.minor > 9 to cover the other case?
There was a problem hiding this comment.
Please add overall coverage report
There was a problem hiding this comment.
Please check #190 (comment)
taohe1012
previously approved these changes
Jun 13, 2025
Signed-off-by: Luis Liu <[email protected]>
Signed-off-by: Luis Liu <[email protected]>
Signed-off-by: Luis Liu <[email protected]>
Signed-off-by: Luis Liu <[email protected]>
baoy1
approved these changes
Jun 13, 2025
P-Cao
approved these changes
Jun 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
https://osj-sio-03-prd.cec.lab.emc.com/job/ansible-pipelines/job/ans-ft-run/490/artifact/ft_report/summary.html
https://osj-sio-03-prd.cec.lab.emc.com/job/ansible-pipelines/job/ans-ft-run/491/artifact/ft_report/summary.html
https://osj-sio-03-prd.cec.lab.emc.com/job/ansible-pipelines/job/ans-ft-run/489/artifact/ft_report/summary.html