Skip to content

Support NFS RDMA enabled key for nfs_global_settings module #191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 16, 2025

Conversation

P-Cao
Copy link
Contributor

@P-Cao P-Cao commented Jun 16, 2025

Description

Support NFS RDMA enabled key for nfs_global_settings module

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, pep8, linting, or security issues
  • I have performed Ansible Sanity test using --docker default
  • [x I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Backward compatibility is not broken

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • UT
    image

  • FT
    9.7
    image
    9.10
    image
    9.11
    image

@codecov-commenter
Copy link

codecov-commenter commented Jun 16, 2025

Codecov Report

Attention: Patch coverage is 94.73684% with 2 lines in your changes missing coverage. Please review.

Project coverage is 90.28%. Comparing base (6c821fb) to head (2a850f2).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
plugins/modules/nfs_global_settings.py 92.30% 0 Missing and 1 partial ⚠️
...ugins/module_utils/mock_nfs_global_settings_api.py 85.71% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #191      +/-   ##
==========================================
+ Coverage   90.27%   90.28%   +0.01%     
==========================================
  Files         143      143              
  Lines       16594    16627      +33     
  Branches     2367     2372       +5     
==========================================
+ Hits        14980    15012      +32     
  Misses        945      945              
- Partials      669      670       +1     
Flag Coverage Δ
units 90.28% <94.73%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@P-Cao P-Cao force-pushed the usr/p_cao/bugfix-nfs_rdma_enabled-support branch from 755bcc9 to d0a254f Compare June 16, 2025 04:44
@P-Cao P-Cao force-pushed the usr/p_cao/bugfix-nfs_rdma_enabled-support branch from d0a254f to b15a77b Compare June 16, 2025 04:49
@P-Cao P-Cao marked this pull request as ready for review June 16, 2025 08:05
forrestxia
forrestxia previously approved these changes Jun 16, 2025
@P-Cao P-Cao merged commit 5f107ee into main Jun 16, 2025
22 checks passed
@P-Cao P-Cao deleted the usr/p_cao/bugfix-nfs_rdma_enabled-support branch June 16, 2025 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants