fix(tui/windows): fix text prompts on windows not displaying any text #463
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… Backspace support
|
I did not know that about raw mode! Very useful info. |
dyc3
approved these changes
Jun 28, 2025
dyc3
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change addresses #389.
The crossterm implementation on Windows places the terminal in Raw Mode, which means:
To address these issues, I've made the echoing explicit to ensure user input is visible, and also added support for Backspace, as it didn't work previously.
I've tested this on Windows and confirmed it's working correctly, with the username and confirmation displayed as expected, and the password remaining hidden. I haven't tested on Linux yet, but it should be working just fine; please kindly verify it first.
fixes #389