Conversation
ilteoood
force-pushed
the
chore/upgrade-deps
branch
from
c3e40b3 to
ed828c0
Compare
mcollina
left a comment
mcollina
left a comment
There was a problem hiding this comment.
the only change needed is the one in borp, the rest is covered by the semver range
| "eslint": "^9.39.2", | ||
| "fastify": "^5.6.2", | ||
| "neostandard": "^0.12.2", | ||
| "pino": "^10.1.1", |
There was a problem hiding this comment.
this should not be updated to a new major.
There was a problem hiding this comment.
@mcollina
Just for my knowledge, can I understand why?
It is a dev dependency here and is used in a test, so even upgrading it to the major version we don't need to release it as breaking change.
There was a problem hiding this comment.
Do we usually randomly upgrade dependencies on packages @fastify/leads?
It is a dev dependency here and is used in a test, so even upgrading it to the major version we don't need to release it as breaking change.
Assumption: even if this is a devDependency and only used in tests, upgrading to a new major effectively changes the version we test against. I don't know if it's an issue here.
There was a problem hiding this comment.
pino ships with pino 9 and tests against pino 9.
|
I re-triggered #543 and it has been merged. |
4 participants
Checklist
npm run test && npm run benchmark --if-presentand the Code of conduct