feat: Downgrade minimatch to v9 to support node 16+#79
Closed
andreiborza wants to merge 1 commit intofastify:mainfrom
Closed
feat: Downgrade minimatch to v9 to support node 16+#79andreiborza wants to merge 1 commit intofastify:mainfrom
andreiborza wants to merge 1 commit intofastify:mainfrom
Conversation
Member
|
What exactly is broken? If the PR got automerged, means that it worked within v18 |
Member
|
and we do not aim to support v16, just v18 onwards. |
Member
|
Discarding for now, we are supporting v18 onwards |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support for node 16 (and more importantly 18) has been dropped again by dependabot bumping to v10 of minimatch. This a redo of #58.
Checklist
npm run test && npm run benchmark --if-presentand the Code of conduct