Conversation
Co-authored-by: iansltx <[email protected]>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #42122 +/- ##
=======================================
Coverage 66.45% 66.45%
=======================================
Files 2516 2516
Lines 201965 201976 +11
Branches 8921 8921
=======================================
+ Hits 134225 134233 +8
- Misses 55595 55599 +4
+ Partials 12145 12144 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull request overview
Updates the GitHub Actions Go test workflows to run the “extended MySQL coverage” matrix against MySQL 8.0.42 instead of 8.0.39, and reflects that change in the user-visible changes entry.
Changes:
- Bumped the extended MySQL test matrix from
mysql:8.0.39tomysql:8.0.42in the Go test workflow. - Bumped the extended MySQL test matrix from
mysql:8.0.39tomysql:8.0.42in the activity Go test workflow. - Updated the
changes/entry to reflect the new MySQL version under test.
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
changes/bump-mysql |
Updates the changelog entry to reference 8.0.42 instead of 8.0.39. |
.github/workflows/test-go.yaml |
Updates the nightly “extended MySQL coverage” matrix to use mysql:8.0.42. |
.github/workflows/test-go-activity.yaml |
Updates the nightly “extended MySQL coverage” matrix to use mysql:8.0.42. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
changes/bump-mysql
Outdated
| @@ -1 +1 @@ | |||
| * Revised which versions Fleet tests MySQL against to 9.5.0 (unchanged), 8.4.8, 8.0.44, and 8.0.39, 8.0.44. | |||
| * Revised which versions Fleet tests MySQL against to 9.5.0 (unchanged), 8.4.8, 8.0.44, and 8.0.42. | |||
There was a problem hiding this comment.
The changes entry reads “tests MySQL against to …” which is grammatically incorrect and a bit confusing. Consider rewording to “tests MySQL against 9.5.0 (unchanged), 8.4.8, 8.0.44, and 8.0.42.”
| * Revised which versions Fleet tests MySQL against to 9.5.0 (unchanged), 8.4.8, 8.0.44, and 8.0.42. | |
| * Revised which versions Fleet tests MySQL against 9.5.0 (unchanged), 8.4.8, 8.0.44, and 8.0.42. |
Updates MySQL version references from 8.0.39 to 8.0.42 in GitHub Actions workflow test matrices to match current Aurora version as of #42120.