Skip to content

This PR is to add comments to TestOptimizeDefaultForFuseWithValue in pkg/ddc/alluxio/transform_optimization_test.go #5102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

xxxxxxyp
Copy link

Ⅰ. Describe what this PR does
This PR adds comments to the 'TestOptimizeDefaultForFuseWithValue' function in pkg/ddc/alluxio/transform_optimization_test.go, clarifying its purpose of updating dataset phase, conditions, and cache status based on runtime configuration. The comments follow the specified format and are placed before the function definition.

Ⅱ. Does this pull request fix one issue?
fixes #5101

Ⅲ. Special notes for reviews
No special notes. The comments adhere to the required format and have been verified against the function's logic for updating Alluxio dataset status.

Copy link

fluid-e2e-bot bot commented Jun 13, 2025

Hi @xxxxxxyp. Thanks for your PR.

I'm waiting for a fluid-cloudnative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

Copy link
Collaborator

@cheyang cheyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

Copy link
Collaborator

@cheyang cheyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix go fmt issue by running make fmt.

Copy link

fluid-e2e-bot bot commented Jun 29, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from cheyang by writing /assign @cheyang in a comment. For more information see:The Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@fluid-e2e-bot fluid-e2e-bot bot removed the approved label Jun 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add comments to TestOptimizeDefaultForFuseWithValue in pkg/ddc/alluxio/transform_optimization_test.go
2 participants