Skip to content

Conversation

@KoBeWi
Copy link
Member

@KoBeWi KoBeWi commented Dec 8, 2025

Closes godotengine/godot-proposals#13802

I ended up also doing some refactoring.

@KoBeWi KoBeWi added this to the 4.x milestone Dec 8, 2025
@KoBeWi KoBeWi requested a review from a team as a code owner December 8, 2025 12:51
@KoBeWi KoBeWi requested review from a team as code owners December 8, 2025 12:51
Copy link
Member

@Calinou Calinou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally, it mostly works as expected. Code looks good to me.

Undo/redo isn't working very consistently though. It will work in simple scenarios (assign material then undo), but if you perform multiple drag-and-drops, the first undo operation will appear to do nothing, then the second undo operation will revert to the state before either of the materials were drag-and-dropped:

shader_bottom_panel_drag_and_drop.mp4

Note that you need to right-click the 3D editor viewport once after the second drag-and-drop so that it gets focus (otherwise, undo will affect the text in the shader editor).

@KoBeWi
Copy link
Member Author

KoBeWi commented Dec 9, 2025

Does the undo issue also happen when you drag a file from FileSystem? If yes then it's not relevant for this PR.

@Calinou
Copy link
Member

Calinou commented Dec 9, 2025

Does the undo issue also happen when you drag a file from FileSystem?

Yes; I guess it should be fixed in a separate PR then.

@KoBeWi KoBeWi modified the milestones: 4.x, 4.7 Dec 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow dragging shader file from shader editor to shader material

2 participants