Fall back to octmap raster path on certain devices & fix issues with the shaders. #114314
+44
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clayjohn
approved these changes
Dec 24, 2025
Member
clayjohn
left a comment
clayjohn
left a comment
There was a problem hiding this comment.
Looks great!
Not blocking for merging this, but can you also check performance with/without the raster path on your Android devices?
I suspect the raster path will be faster for some android devices.
Contributor
Author
|
Tried on a Mali-G76 with a reflection probe set to Update Always: Compute path: 25.9 mspf I also tried on a PowerVR GE8320. The lower mip levels are completely corrupted on the compute path, so we may need to redirect these devices to the raster path regardless. |
blueskythlikesclouds
force-pushed
the
octmap-raster-fallback
branch
from
a2bb4d8 to
205d981
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Octmaps always take the compute path, even on the Mobile renderer, but not all devices support creating storage images in the A2B10G10R10 format. This is the case on Adreno 512 on my old phone. As part of this change, I also fixed several bugs in the raster shaders and ported the ARM vertex shader workaround to them, since this path can now be used on mobile devices.