Support composition layers anywhere in the tree #114324
Conversation
m4gr3d
force-pushed
the
support_composition_layers_anywhere_in_tree
branch
from
87fc625 to
6627795
Compare
|
|
||
| void OpenXRCompositionLayer::_remove_fallback_node() { | ||
| ERR_FAIL_COND(fallback != nullptr); | ||
| ERR_FAIL_COND(fallback == nullptr); |
There was a problem hiding this comment.
@dsnopek Looks like the cond check was inverted, or am I misreading this logic?
There was a problem hiding this comment.
Hm, at first glance, I think you're right! I wonder why we haven't had issues with this in the past, though
| if (Object::cast_to<XROrigin3D>(get_parent()) != nullptr) { | ||
| xf = get_transform(); | ||
| } else { | ||
| xf = get_global_transform(); |
There was a problem hiding this comment.
Does this still work when the XROrigin3D is moved away from (0, 0, 0) and/or rotated?
I would have expected this to need something like (untested):
| xf = get_global_transform(); | |
| xf = XRServer::get_singleton()->get_world_origin().affine_inverse() * get_global_transform(); |
| case NOTIFICATION_LOCAL_TRANSFORM_CHANGED: { | ||
| case NOTIFICATION_TRANSFORM_CHANGED: { |
There was a problem hiding this comment.
Could we still use NOTIFICATION_LOCAL_TRANSFORM_CHANGED when XROrigin3D is the parent, and only use NOTIFICATION_TRANSFORM_CHANGED when putting it elsewhere? NOTIFICATION_TRANSFORM_CHANGED can happen way more frequently than NOTIFICATION_LOCAL_TRANSFORM_CHANGED
| warnings.push_back(RTR("OpenXR composition layers must have an XROrigin3D node as their parent.")); | ||
| warnings.push_back(RTR("OpenXR composition layers must have an XROrigin3D node as their ancestor.")); |
There was a problem hiding this comment.
Wait, I thought the idea was that you could put it anywhere? Why does it still need to have XROrigin3D as an ancestor?
2 participants
No description provided.