GLTF: dupe images during serialization to prevent segfaults #114354
+25
−32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fire
approved these changes
Dec 26, 2025
aaronfranke
approved these changes
Dec 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TextureStorage for the real renderers caches images in debug builds, and the dummy texture storage caches them in all builds. Thus, if GLTFDocument::serialize() is running on multiple threads and is serializing models that share the same material, we run the risk of a segfault when we modify the images during serializing materials.
@clayjohn suggested that we should duplicate the images when we modify them to avoid this. Thus, I have modified it such that whenever we decompress and/or modify an image, we duplicate the image first.