Refactor dock slot selector #114360
Open
Refactor dock slot selector #114360
+172
−165
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improves how the dock grid in the dock popup is defined. Instead of hard-coded position and size for each dock slot, the slots are now registered with their position in an abstract grid. This information is then used to draw the slots and handle input. The new DockSlotGrid class is responsible for that. Its minimum size is derived from the grid instead of also being hard-coded.
I reorganized the slot grid to better match the actual editor layout (i.e. the main screen is visibly higher than bottom panel).
Before:
After:
(ignore the different colors, it's unrelated)