Add early-exit validation to MapAsync for already mapped buffers and … #42
+73
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Commit
This PR adds an early-exit check in
BufferBase::APIMapAsync()
to prevent callingMapAsync on a buffer that is already mapped (either via
MapAsync
ormappedAtCreation
).It improves developer feedback and avoids redundant validation, while returning
a null future and triggering the error callback early.
Key Changes
ValidateMapAsync()
dawn::EmitWarning
Future
on invalid useWGPUMapAsyncStatus_Error
Test Coverage
Added
MapAsyncFailsWhenAlreadyMapped
inBufferValidationTests
to verify behavior.CI Note (Temporary Workaround)
This PR includes a temporary local patch to work around a known Protobuf build issue on macOS
It can be removed once the CI or Protobuf dependency is updated.