[ENH] test suite cleanup #950
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtsokol
force-pushed
the
test-suite-cleanup
branch
2 times, most recently
from
97527d9 to
0ab7035
Compare
mtsokol
force-pushed
the
test-suite-cleanup
branch
from
0ab7035 to
bc85005
Compare
iindyk
reviewed
Jul 21, 2025
| @@ -126,6 +126,16 @@ main() { | |||
| $PYTHON_BIN -m pip install --find-links="${OUTPUT_DIR}/all_dist" --pre "${PKG_NAME}" | |||
| $PYTHON_BIN -m pip install jax | |||
| $PYTHON_BIN grain/_src/core/smoke_test_with_jax.py | |||
| $PYTHON_BIN grain/_src/core/tree_lib_jax_test.py | |||
There was a problem hiding this comment.
having few tests run differently from the rest is a bit brittle imo. Is there a way for us to run a test suite with something like pytest? or unittest discover?
There was a problem hiding this comment.
Right here is just a minimal change to make it work - let me move that to actual pytest call tomorrow!
There was a problem hiding this comment.
yeah, make sense, thanks. I think ideally we would run the whole test suit together in the long term
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @iindyk,
This PR fixes ubuntu-arm JAX import failures by moving these test to after
bazel build/test.It also adds skips to all tests that are incompatible with Windows platform.
With this change "Run unit tests ✅" should work, here's a job: https://github.com/mtsokol/grain/actions/runs/16372765054
📚 Documentation preview 📚: https://google-grain--950.org.readthedocs.build/