actions: add runner version to apt cache key#218
Merged
miek merged 1 commit intogreatscottgadgets:mainfrom Feb 12, 2025
Merged
Conversation
martinling
approved these changes
Feb 12, 2025
Member
martinling
left a comment
martinling
left a comment
There was a problem hiding this comment.
Bodgetastic.
Note that if we ever change the set of packages to be installed, we'll need to add our own value to the cache key as well, so that we can bump it without the runner version having changed.
But we can just do that when we first need it.
Member
Author
|
Ahh, I was wondering why the version was already set - that makes sense. Though it looks like it already adds the list of packages to the hash anyway (https://github.com/awalsh128/cache-apt-pkgs-action/blob/master/pre_cache_action.sh#L61-L73) so it might be fine? |
Member
|
Oh cool, if it's already including that in the hash then we shouldn't need to do anything. 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds the actions runner image version to the apt cache key, so it should get rebuilt when the runner is updated.