Ensure that we don't change n_items() without an items_changed signal#219
Merged
miek merged 1 commit intogreatscottgadgets:mainfrom Mar 5, 2025
Merged
Ensure that we don't change n_items() without an items_changed signal#219miek merged 1 commit intogreatscottgadgets:mainfrom
miek merged 1 commit intogreatscottgadgets:mainfrom
Conversation
In the ListModel interface, we must always report a n_items() that is consistent with the history of `items_changed` signals we have emitted. So keep a published row count separately from our internal counts, and update it just before emitting an `items_changed` signal. Fixes crashes in GTK where the view gets out of sync with the model.
miek
approved these changes
Mar 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the
ListModelinterface, we must always report an_items()that is consistent with the history ofitems_changedsignals we have emitted.So keep a published row count separately from our internal counts, and update it just before emitting an
items_changedsignal. Fixes crashes in GTK where the view gets out of sync with the model.Initially triggered by #150, but I think it's possible for the crash to occur independently of that.