Skip to content

vanilla: Add GHC 9.8.4 #265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 3, 2024
Merged

vanilla: Add GHC 9.8.4 #265

merged 1 commit into from
Dec 3, 2024

Conversation

bgamari
Copy link
Collaborator

@bgamari bgamari commented Nov 29, 2024

@bgamari bgamari force-pushed the wip/ghc-9.8.4 branch 4 times, most recently from 71349ba to 71ee9b5 Compare November 29, 2024 19:11
@bgamari
Copy link
Collaborator Author

bgamari commented Nov 29, 2024

I have no explanation for why GitHub refuses my commit's signature; I have explicitly overridden the authorship metadata to precisely match that of my public key, the key is associated with my GitHub account, GitHub seemingly recognizes the key as the signing key, and I can readily verify the signature locally.

@phadej
Copy link

phadej commented Nov 29, 2024

I give you a hint:

commit 71ee9b5e5e48d45651547cf0cc00b1ed1960dc91 (origin/wip/ghc-9.8.4)
Author: Benjamin Gamari <[email protected]>
Commit: Ben Gamari <[email protected]>

@bgamari
Copy link
Collaborator Author

bgamari commented Nov 29, 2024

I give you a hint:

commit 71ee9b5e5e48d45651547cf0cc00b1ed1960dc91 (origin/wip/ghc-9.8.4)
Author: Benjamin Gamari <[email protected]>
Commit: Ben Gamari <[email protected]>

Oh bah. I neglected to consider that --author wouldn't override the committer name.

@bgamari
Copy link
Collaborator Author

bgamari commented Nov 29, 2024

The commit signature should now be valid.

@bgamari bgamari force-pushed the wip/ghc-9.8.4 branch 3 times, most recently from f6af21a to aa6efd9 Compare December 2, 2024 14:36
Windows:
unknown_versioning:
dlHash: 184c9184d6439f1da8bca0214011ef6074fb5946eaa5840dc0c3e884515d7c52
dlOutput: ghc-9.8.4-x86_64-windows.tar.xz
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

delete

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This disagrees with the filename of dlUri; is this okay?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The main point of dlOutput is to avoid collisions in case the dlUri is not unique enough.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, this is useful information.

The natural next question is then: how would one find this out? Is the format of this file documented somewhere?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All normal bindists are unique, because they contain information on:

  • version
  • architecture
  • platform
  • distro

I have not seen an overlap in bindist names so far from GHC pipeline.

This was added for cross bindists afair that had no unique names.

@hasufell
Copy link
Member

hasufell commented Dec 3, 2024

@hasufell hasufell merged commit 06aa4f6 into develop Dec 3, 2024
47 of 57 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants