-
Notifications
You must be signed in to change notification settings - Fork 31
vanilla: Add GHC 9.8.4 #265
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
71349ba
to
71ee9b5
Compare
I have no explanation for why GitHub refuses my commit's signature; I have explicitly overridden the authorship metadata to precisely match that of my public key, the key is associated with my GitHub account, GitHub seemingly recognizes the key as the signing key, and I can readily verify the signature locally. |
I give you a hint:
|
Oh bah. I neglected to consider that |
71ee9b5
to
a3eadad
Compare
The commit signature should now be valid. |
f6af21a
to
aa6efd9
Compare
Windows: | ||
unknown_versioning: | ||
dlHash: 184c9184d6439f1da8bca0214011ef6074fb5946eaa5840dc0c3e884515d7c52 | ||
dlOutput: ghc-9.8.4-x86_64-windows.tar.xz |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
delete
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This disagrees with the filename of dlUri
; is this okay?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The main point of dlOutput
is to avoid collisions in case the dlUri
is not unique enough.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, this is useful information.
The natural next question is then: how would one find this out? Is the format of this file documented somewhere?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All normal bindists are unique, because they contain information on:
- version
- architecture
- platform
- distro
I have not seen an overlap in bindist names so far from GHC pipeline.
This was added for cross bindists afair that had no unique names.
aa6efd9
to
5dd021b
Compare
Bindist installation workflow:
https://github.com/haskell/ghcup-metadata/actions/runs/12089659430