DRAFT: Completions for cabal.project files, hls-cabal-project-plugin#4680
Draft
rm41339 wants to merge 3 commits intohaskell:masterfrom
Draft
DRAFT: Completions for cabal.project files, hls-cabal-project-plugin#4680rm41339 wants to merge 3 commits intohaskell:masterfrom
rm41339 wants to merge 3 commits intohaskell:masterfrom
Conversation
fendor
requested changes
Jul 31, 2025
| ("test-options:", noopCompleter), | ||
| ("benchmark-options:", noopCompleter), | ||
| ("coverage:", constantCompleter ["False", "True"]), | ||
| ("ghc-options:", noopCompleter) |
Collaborator
There was a problem hiding this comment.
Comment on lines
+20
to
+22
| data TopLevelStanza | ||
| = Package | ||
| | ProgramOptions |
fendor
reviewed
Jul 31, 2025
| @@ -0,0 +1,177 @@ | |||
| {-# LANGUAGE OverloadedStrings #-} | |||
Collaborator
There was a problem hiding this comment.
This file seems to be unnecessary except contextToCompleter.
fendor
requested changes
Jul 31, 2025
| getTextEditTexts :: [CompletionItem] -> [T.Text] | ||
| getTextEditTexts compls = mapMaybe (^? L.textEdit . _Just . _L . L.newText) compls | ||
|
|
||
| fileCompleterTests :: TestTree |
Collaborator
There was a problem hiding this comment.
We don't need to test this here, as it is already tested by the hls-cabal-plugin
…ll#4713) eglot docs recommend using property lists Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Draft of completions support for cabal.project plugin for GSoC 2025.
Still in progress!