Skip to content

Enable crossModule option by default #4817

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Aster89 wants to merge 2 commits into
base: master
Choose a base branch
from
+8 −8
Open

Enable crossModule option by default #4817

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ea86fce
Fix #4815
Aster89 Jan 29, 2026
659b51d
change json files
Aster89 Jan 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/configuration.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ Plugins have a generic config to control their behaviour. The schema of such con
- `haskell.plugin.eval.config.diff`, default true: When reloading haddock test results in changes, mark it with WAS/NOW.
- `haskell.plugin.eval.config.exception`, default false: When the command results in an exception, mark it with `*** Exception:`.
- `rename`:
- `haskell.plugin.rename.config.crossModule`, default false: Enables renaming across modules (experimental)
- `haskell.plugin.rename.config.crossModule`, default true: Enables renaming across modules (experimental)
- `ghcide-completions`:
- `haskell.plugin.ghcide-completions.config.snippetsOn`, default true: Inserts snippets when using code completions.
- `haskell.plugin.ghcide-completions.config.autoExtendOn`, default true: Extends the import list automatically when completing a out-of-scope identifier.
Expand Down
2 changes: 1 addition & 1 deletion plugins/hls-rename-plugin/src/Ide/Plugin/Rename.hs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -291,4 +291,4 @@ replaceModName name mbModName =
properties :: Properties '[ 'PropertyKey "crossModule" 'TBoolean]
properties = emptyProperties
& defineBooleanProperty #crossModule
"Enable experimental cross-module renaming" False
"Enable experimental cross-module renaming" True
2 changes: 1 addition & 1 deletion test/testdata/schema/ghc912/default-config.golden.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,7 +132,7 @@
},
"rename": {
"config": {
"crossModule": false
"crossModule": true
},
"globalOn": true
},
Expand Down
2 changes: 1 addition & 1 deletion test/testdata/schema/ghc912/markdown-reference.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@
## rename
| Property | Description | Default | Allowed values |
| --- | --- | --- | --- |
| `crossModule` | Enable experimental cross-module renaming | `False` |   |
| `crossModule` | Enable experimental cross-module renaming | `True` |   |

## semanticTokens
| Property | Description | Default | Allowed values |
Expand Down
2 changes: 1 addition & 1 deletion test/testdata/schema/ghc912/vscode-extension-schema.golden.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -304,7 +304,7 @@
"type": "boolean"
},
"haskell.plugin.rename.config.crossModule": {
"default": false,
"default": true,
"markdownDescription": "Enable experimental cross-module renaming",
"scope": "resource",
"type": "boolean"
Expand Down
2 changes: 1 addition & 1 deletion test/testdata/schema/ghc914/default-config.golden.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,7 @@
},
"rename": {
"config": {
"crossModule": false
"crossModule": true
},
"globalOn": true
},
Expand Down
2 changes: 1 addition & 1 deletion test/testdata/schema/ghc914/markdown-reference.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
## rename
| Property | Description | Default | Allowed values |
| --- | --- | --- | --- |
| `crossModule` | Enable experimental cross-module renaming | `False` |   |
| `crossModule` | Enable experimental cross-module renaming | `True` |   |

## semanticTokens
| Property | Description | Default | Allowed values |
Expand Down
2 changes: 1 addition & 1 deletion test/testdata/schema/ghc914/vscode-extension-schema.golden.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -268,7 +268,7 @@
"type": "boolean"
},
"haskell.plugin.rename.config.crossModule": {
"default": false,
"default": true,
"markdownDescription": "Enable experimental cross-module renaming",
"scope": "resource",
"type": "boolean"
Expand Down
Loading