Add map for mutable vector which modify it in place.#545
Add map for mutable vector which modify it in place.#545Shimuuar merged 4 commits intohaskell:masterfrom
Conversation
lehins
left a comment
lehins
left a comment
There was a problem hiding this comment.
Very nice. inPlace is a fine suffix IMHO
Shimuuar
force-pushed
the
mutable_mapM
branch
from
06943b5 to
0d3a6fd
Compare
Shimuuar
force-pushed
the
mutable_mapM
branch
from
9184bca to
367a037
Compare
|
I've added tests and specializations. PR is done I also disabled |
lehins
left a comment
lehins
left a comment
There was a problem hiding this comment.
Nice!
Thank you for your work!
vector/vector.cabal
Outdated
| -- Disable pointless warning about partial functions | ||
| if impl(ghc >= 9.8) | ||
| Ghc-Options: -Wno-x-partial |
There was a problem hiding this comment.
I'd suggest moving this to the test suite, where this is actually relevant, instead of also applying it to the library.
There was a problem hiding this comment.
Done. I consider this warning somewhat misguide so I'm fine with disabling it globally.
There was a problem hiding this comment.
I am actually very happy that this warning exists. IMHO, there is never a case when head or tail should be used outside of testing and throw away code
Shimuuar
force-pushed
the
mutable_mapM
branch
from
367a037 to
b2e00f2
Compare
2 participants
This is last part of API for mutable vectors
Naming was discussed at length in #334. I somewhat arbitrarily picked variant with
InPlacesuffix. But I don't feel strongly about it and this is good moment for final decision. Bikeshedding season is onFixes #334