Skip to content

Build PhoneBlock immediately after checkout#204

Open
SchulteDev wants to merge 3 commits intohaumacher:masterfrom
SchulteDev:refactor/dkim-library
Open

Build PhoneBlock immediately after checkout#204
SchulteDev wants to merge 3 commits intohaumacher:masterfrom
SchulteDev:refactor/dkim-library

Conversation

@SchulteDev
Copy link
Contributor

This PR contains minor changes to the project build so that the build can be successfully executed locally immediately after a checkout.

  1. Use of Jitpack to directly use your fix https://github.com/haumacher/java-utils-mail-dkim/tree/fix-automatic-module-name without needed extra building it locally.
  2. Adjustment of the filtering of the .phoneblock file.
    - Remove global <filters> configuration that was applied during process-resources phase
    - Keep filtering in maven-war-plugin for deployment-time configuration injection
    - Allow developers to compile and test without needing environment-specific .phoneblock file
    

Fixes #202

- Remove global <filters> configuration that was applied during process-resources phase
- Keep filtering in maven-war-plugin for deployment-time configuration injection
- Allow developers to compile and test without needing environment-specific .phoneblock file

Fixes haumacher#202
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Cannot build locally because of unavailable dependency org.simplejavamail:utils-mail-dkim:3.2.1-haumacher

1 participant