Fix kicking IRC users on plumbed rooms when they change their nick#311
Open
jlu5 wants to merge 1 commit intohifi:masterfrom
Open
Fix kicking IRC users on plumbed rooms when they change their nick#311jlu5 wants to merge 1 commit intohifi:masterfrom
jlu5 wants to merge 1 commit intohifi:masterfrom
Conversation
Heisenbridge translates IRC nick changes to Matrix by kicking the puppet with the old nick and joining a new one with the new nick. However, the IRC user list is not updated before kicking the old puppet; therefore the on_mx_leave handler ends up kicking the IRC user's old nick. Finally, some IRCds allow kicks to track nick changes, so the end result is that the person changing nicks gets kicked from IRC. on_mx_leave already checks is_on_channel, so the quick fix is to update the on_channel list for each channel to reflect nick changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Heisenbridge translates IRC nick changes to Matrix by kicking the puppet with the old nick and joining a new one with the new nick. However, the IRC user list is not updated before kicking the old puppet; therefore the on_mx_leave handler ends up kicking the IRC user's old nick. Finally, some IRCds allow kicks to track nick changes, so the end result is that the person changing nicks gets kicked from IRC.
on_mx_leave already checks is_on_channel, so the quick fix is to update the on_channel list for each channel to reflect nick changes.
Fixes #279