Add token streaming for text generation #130
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
You can run |
Member
Oh i missed that! We don't use it from Node in moon-landing, @SBrandeis? |
coyotte508
reviewed
Apr 5, 2023
Member
coyotte508
left a comment
coyotte508
left a comment
There was a problem hiding this comment.
Thanks a lot for this PR @vvmnnnkv !
There's a big refacto request (streams => async generators), it's maybe more than you bargained for when opening the PR ^^
Aschen
reviewed
Apr 5, 2023
coyotte508
reviewed
Apr 6, 2023
coyotte508
approved these changes
Apr 6, 2023
Member
coyotte508
left a comment
coyotte508
left a comment
There was a problem hiding this comment.
Thanks a lot! 🤗
cc @radames @TimMikeladze :)
Member
|
A demo is live with the feature: https://huggingface.co/spaces/huggingfacejs/streaming-text-generation It's released in version 1.7.1. Thanks again :) |
Member
|
nice demo! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An attempt to fix #78 :-)
Added a separate method
textGenerationStream(similar to python client).Not using
fetch-event-sourcebecause it doesn't play well with nodejs (Azure/fetch-event-source#20).But should be easy to replace in the future.