fix(models): handle string content when merging consecutive same-role messages#2083
Open
NIK-TIGER-BILL wants to merge 1 commit intohuggingface:mainfrom
Open
Conversation
… messages
When consecutive messages have the same role and plain string content,
prepare_completion_kwargs() fails with an AssertionError because it
asserts content is a list before merging.
Fix by normalizing string content to [{"type": "text", "text": ...}]
format before attempting to merge, and handling the case where the
previous message in output_message_list also has plain string content.
This allows LiteLLMModel (and other ApiModel subclasses) to accept
multiple consecutive system messages, a common pattern for layered
or compositional system instructions.
Fixes huggingface#1972
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
LiteLLMModel(and anyApiModelsubclass) fails with anAssertionErrorwhen the input message list contains multiple consecutive messages with the same role (e.g., twosystemmessages in a row):The
prepare_completion_kwargs()helper inmodels.pymerges consecutive same-role messages but asserts thatmessage.contentis a list before merging. When messages are provided with plain string content (the common dict format), this assertion fails.Fix
[{"type": "text", "text": ...}]before mergingflatten_messages_as_textpath to handle string content gracefullyFixes #1972