Fix action_type being overwritten in interactive mode#2085
Open
gggolddeity wants to merge 1 commit intohuggingface:mainfrom
Open
Fix action_type being overwritten in interactive mode#2085gggolddeity wants to merge 1 commit intohuggingface:mainfrom
gggolddeity wants to merge 1 commit intohuggingface:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In interactive_mode() in cli.py, the user picks action_type via Prompt.ask (code or tool_calling), but a few lines below there's a hardcoded action_type = "code" that overwrites the choice. Because of this, selecting
tool_calling in interactive mode never actually works — the agent always runs as CodeAgent.
The fix is just removing that redundant assignment so the user's selection is actually used.
This bug has been there since the feature was introduced in 4dbab6d