Search box for when you click on a course page and the professor box#1007
Open
JasonNguyen067 wants to merge 10 commits intomainfrom
Open
Search box for when you click on a course page and the professor box#1007JasonNguyen067 wants to merge 10 commits intomainfrom
JasonNguyen067 wants to merge 10 commits intomainfrom
Conversation
JasonNguyen067
temporarily deployed
to
staging-1007
GitHub Actions
Inactive
JasonNguyen067
temporarily deployed
to
staging-1007
GitHub Actions
Inactive
CadenLee2
reviewed
Mar 5, 2026
Comment on lines
+25
to
+29
| .MuiInputBase-input { | ||
| // @todo: try to get rid of this, likely through a variant | ||
| background-color: var(--mui-palette-overlay-overlay1); | ||
| width: 150px; | ||
| } |
Collaborator
There was a problem hiding this comment.
We should be able to remove this after Derrick's select PR #968 (which updates theming) gets merged, so let's wait until then for this
Comment on lines
+190
to
+191
| <Autocomplete | ||
| options={profCourseOptions ?? []} |
Collaborator
There was a problem hiding this comment.
Some edge case suggestions:
- Shouldn't have the X option to clear the current option, because that means there's no data and the graphs look weird
- May want an empty state for when there's no prof data
Comment on lines
+193
to
+195
| value={profCourseOptions?.find((o) => o.value === profCourseSelectedValue) ?? null} | ||
| onChange={(_, newValue) => updateProfCourse(newValue?.value ?? null)} | ||
| isOptionEqualToValue={(option, value) => option.value === value.value} |
Collaborator
There was a problem hiding this comment.
Once Derrick's PR gets merged we can see if the way we structure these props follows the same conventions/style as that one
JasonNguyen067
had a problem deploying
to
staging-1007
GitHub Actions
Failure
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a search box
You can test this by navigating to a course, clicking on the professor and typing a professors name in the search box.