Values Store initial implementation#228
Conversation
Summary of ChangesHello @akremenetsky, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces the foundational "Values Store" system, designed to provide a flexible and dynamic way to manage configuration values across different environments and elements. It establishes core entities like Profiles for environment adaptation, Values for typed data storage, and Variables for intelligent value resolution. The changes integrate this new system into the existing API and service architecture, allowing elements to be associated with profiles and enabling variables to automatically determine their values based on these profiles or explicit selections. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request introduces the Values Store (VS) feature, which includes profiles, values, and variables to adapt installations for various environments. The changes span multiple files, adding new models, API endpoints, and builder services to support this functionality. The review focuses on identifying potential issues related to correctness and maintainability, particularly in the new code related to VS.
14dbbe7 to
3702ec7
Compare
2fe77b9 to
c743b9b
Compare
There main entities in VS: - Profiles. Allow to adaptate installation for various environments such as local development, stage, production. - Values. Allow to specify values of different types such as int, float, list, object, string, bool. - Variables. The entities with internal logic to calculate value based on profiles or values. Support of profiles as on the global scope as the element scope. Additional actions in EM API to set and clear profiles. Signed-off-by: Anton Kremenetsky <anton.kremenetsky@gmail.com>
c743b9b to
def64c4
Compare
There main entities in VS:
Support of profiles as on the global scope as the element scope. Additional actions in EM API to set and clear profiles.
Closes #163