policy(v2): make PolicyEvaluationInfo fields mandatory#503
Closed
gaojiaqi7 wants to merge 1 commit intointel:mainfrom
Closed
policy(v2): make PolicyEvaluationInfo fields mandatory#503gaojiaqi7 wants to merge 1 commit intointel:mainfrom
gaojiaqi7 wants to merge 1 commit intointel:mainfrom
Conversation
Contributor
|
still draft? |
gaojiaqi7
force-pushed
the
1024/policy_evaluation_data
branch
from
cd38029 to
d46e0d3
Compare
gaojiaqi7
force-pushed
the
1024/policy_evaluation_data
branch
3 times, most recently
from
f2d7984 to
3a0b763
Compare
jyao1
reviewed
Nov 10, 2025
src/policy/src/v2/policy.rs
Outdated
Comment on lines
447
to
423
| relative_reference: Option<u32>, | ||
| relative_reference: u32, |
jyao1
reviewed
Nov 10, 2025
src/migtd/src/mig_policy.rs
Outdated
| .get_engine_svn_by_report(&report_value) | ||
| .and_then(|migtd_svn| policy.servtd_identity.get_tcb_level_by_svn(migtd_svn)) | ||
| .cloned() | ||
| .unwrap_or_default() |
jyao1
reviewed
Nov 10, 2025
src/policy/src/v2/policy.rs
Outdated
Comment on lines
61
to
76
| pub tcb_date: Option<String>, | ||
| pub tcb_date: String, | ||
|
|
||
| /// The status of the TCB | ||
| pub tcb_status: Option<String>, | ||
| pub tcb_status: String, | ||
|
|
||
| /// The TCB evaluation data number used to track TCB revocations and updates | ||
| pub tcb_evaluation_number: Option<u32>, | ||
| pub tcb_evaluation_number: u32, | ||
|
|
||
| /// The FMSPC of platform | ||
| pub fmspc: Option<[u8; 6]>, | ||
| pub fmspc: [u8; 6], | ||
|
|
||
| /// The status of the MigTD TCB | ||
| pub migtd_tcb_status: Option<String>, | ||
| pub migtd_tcb_status: String, | ||
|
|
||
| /// The date of the MigTD TCB in ISO-8601 format, e.g. "2023-06-19T00:00:00Z" | ||
| pub migtd_tcb_date: Option<String>, | ||
| pub migtd_tcb_date: String, |
Contributor
|
please also fix the conflict. |
gaojiaqi7
force-pushed
the
1024/policy_evaluation_data
branch
from
3a0b763 to
bda87ac
Compare
jyao1
approved these changes
Nov 12, 2025
A new() constructor is added to centralize validation logic. Conditionally requires MigTD TCB information, allowing it to be absent only when the test_disable_tcb_mapping_check feature is enabled for testing. Signed-off-by: Jiaqi Gao <jiaqi.gao@intel.com>
gaojiaqi7
force-pushed
the
1024/policy_evaluation_data
branch
from
bda87ac to
94b24e0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The policy may choose not to enforce checks on these fields.
Close #478