Support Logging for vmcall-raw feature #528
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
mgudaram
force-pushed
the
Logging
branch
3 times, most recently
from
d419cc8 to
1657771
Compare
src/migtd/src/migration/session.rs
Outdated
| #[cfg(feature = "vmcall-raw")] | ||
| static NUM_VCPUS: AtomicU32 = AtomicU32::new(0); | ||
|
|
||
| #[cfg(feature = "vmcall-raw")] | ||
| static LOGAREA_CREATED: AtomicBool = AtomicBool::new(false); | ||
|
|
||
| #[cfg(feature = "vmcall-raw")] | ||
| static LOGAREA_INITIALIZED: AtomicBool = AtomicBool::new(false); | ||
|
|
||
| #[cfg(feature = "vmcall-raw")] | ||
| static LOGENTRY_ID: AtomicU64 = AtomicU64::new(0); | ||
|
|
||
| #[cfg(feature = "vmcall-raw")] | ||
| static MAXLOGLEVEL: AtomicU8 = AtomicU8::new(0); | ||
|
|
There was a problem hiding this comment.
can we create a data structure to include all logging related items?
There was a problem hiding this comment.
can we create a data structure to include all logging related items?
I moved them into a data structure in logging.rs
|
Please clarify how you do the unit test. If you have covered all corner cases, including
|
src/migtd/src/migration/session.rs
Outdated
| #[cfg(feature = "vmcall-raw")] | ||
| pub fn create_logarea() -> Result<()> { |
There was a problem hiding this comment.
can we move all logging related feature to a separate log.rs file?
There was a problem hiding this comment.
can we move all logging related feature to a separate log.rs file?
sure jiewen, since session.rs uses existing crate log::, is it okay to rename the file to logging.rs? it would help resolve any future confusions.
There was a problem hiding this comment.
My recommendation is:
- Keep old sesson.rs.
- Create a new logging.rs and put all logging related definition/function there.
- The rest file just call the logging interface in logging.rs.
Signed-off-by: Gudaram, Meghana <[email protected]>
On my end, I have run ~50 migrations with logging using loopback mechanism. Few migrations exhaust the circular buffer. I will look into adding unit test support in the logging.rs. |
2 participants
No description provided.