-
Notifications
You must be signed in to change notification settings - Fork 53
telemetry additions and adjustments #538
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Harper, Jason M <[email protected]>
Signed-off-by: Harper, Jason M <[email protected]>
Signed-off-by: Harper, Jason M <[email protected]>
Signed-off-by: Harper, Jason M <[email protected]>
Signed-off-by: Harper, Jason M <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates telemetry functionality by upgrading the processwatch tool version, refining instruction mix collection, and introducing support for Gaudi and PDU telemetry as hidden features controlled by environment variables.
Key changes:
- Upgrades processwatch from commit hash to version v1.3 and modifies instruction mix telemetry to collect all categories without filtering
- Hides Gaudi telemetry from CLI, enabling it via PERFSPECT_GAUDI_HLSMI_PATH environment variable
- Adds PDU telemetry infrastructure with placeholder implementation, enabled via four environment variables
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| tools/Makefile | Updates processwatch version from commit hash to v1.3 |
| internal/script/script_defs.go | Refactors instruction mix script to collect all categories, updates Gaudi script path handling, adds PDU telemetry placeholder |
| internal/report/table_defs.go | Adds PDU telemetry table definition and placeholder rendering function |
| internal/report/render_html.go | Enhances chart rendering to support hidden datasets, refactors instruction mix visualization to sort and hide zero-sum categories |
| cmd/telemetry/telemetry.go | Removes instruction mix filter flag, adjusts frequency defaults, moves Gaudi/PDU telemetry to environment variable control |
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
…pport hidden dataset flags Signed-off-by: Harper, Jason M <[email protected]>
Signed-off-by: Harper, Jason M <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.
Signed-off-by: Harper, Jason M <[email protected]>
Uh oh!
There was an error while loading. Please reload this page.