Skip to content

fix: update only allow.txt with new words #5070

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

Shrishti1701
Copy link
Contributor

@Shrishti1701 Shrishti1701 commented May 5, 2025

@terriko
Fixed a spelling mistake in the CLI help message related to vulnerability scanning. This closes issue #5044.

@terriko terriko changed the title Fix: Remove unintended changes to expect.txt, update only allow.txt fix: Remove unintended changes to expect.txt, update only allow.txt May 6, 2025
@terriko terriko changed the title fix: Remove unintended changes to expect.txt, update only allow.txt fix: update only allow.txt with new words May 6, 2025
Copy link
Contributor

@terriko terriko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

spellcheck error is hard to read but...

Unrecognized words (1)\n\nsboms\n\n

These words are not needed and should be removed\naar aiohttp cdx cwes cyclonedx getbootstrap GMS Interoperability NOTKNOWN pyyaml rdf sbom skontar spdx Svunknown swid urllib \n

@Shrishti1701
Copy link
Contributor Author

@terriko I deleted the unrecognized word from the allow.txt.

@Shrishti1701 Shrishti1701 force-pushed the fix-spelling-issue-5044 branch from a98b85e to 1161c3d Compare May 7, 2025 05:38
Copy link
Contributor

@terriko terriko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like CDX got removed by mistake (possibly also SPDX?) and you'll need to keep the blank line after zstd because it won't work without it. (I think we have that documented but it is easy to miss. It's a quirk of the workflow we're using.)

@Shrishti1701
Copy link
Contributor Author

Thanks for catching that! I’ll go ahead and re-add CDX (and SPDX if needed), and make sure to include the blank line after zstd. Appreciate the heads-up on that quirk — I’ll refer to the documentation going forward to avoid missing it again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants