Skip to content

Add PCI device ID and address to resource attributes #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

solidDoWant
Copy link
Contributor

Right now, only "model" and "family" fields are available as device attributes for resource claim selection. When the driver populates these with "Unknown" (which occurs when this field is missing an entry for the device ID), there is not enough information to tell the device plugin which device to use.

This adds the PCI device ID and address, which allows for selecting semi-specific models of cards even when the model and family names have not been added to the driver.

@byako
Copy link
Contributor

byako commented Jun 12, 2025

Thanks for the PR!
These two fields (PCI Address and PCI Device ID) make up ResourceSlice's Device UID - is that not enough for your purposes?

@solidDoWant
Copy link
Contributor Author

These two fields (PCI Address and PCI Device ID) make up ResourceSlice's Device UID - is that not enough for your purposes?

Unfortunately, as far as I can tell, these cannot be queried via a device selector in a resource claim template. From the KEP, only the attributes, driver, and capacity fields are available.

@solidDoWant solidDoWant requested a review from byako June 12, 2025 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants